tools/telemetry/telemetry/tab_test_case.py - Issue 11819018: [Telemetry] Clean separation between tab (public API) and tab_backend (Chrome implementation). Flat…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/tab_test_case.py

Issue 11819018: [Telemetry] Clean separation between tab (public API) and tab_backend (Chrome implementation). Flat… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make unit tests pass and merge. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/tab_test_case.py

diff --git a/tools/telemetry/telemetry/tab_test_case.py b/tools/telemetry/telemetry/tab_test_case.py

index c890ca854f93b9cfced173af60d83b3c042dc51b..cbc6b0f65cdce8b45980fdafe652a535c0ffb7ae 100644

--- a/tools/telemetry/telemetry/tab_test_case.py

+++ b/tools/telemetry/telemetry/tab_test_case.py

@@ -34,7 +34,7 @@ class TabTestCase(unittest.TestCase):

def tearDown(self):

if self._tab:

- self._tab.Disconnect()

+ self._tab.Close()

if self._browser:

self._browser.Close()

« no previous file with comments | « tools/telemetry/telemetry/tab_backend.py ('k') | tools/telemetry/telemetry/tab_unittest.py » ('j') | no next file with comments »