Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(194)

Unified Diff: tools/telemetry/telemetry/inspector_console.py

Issue 11819018: [Telemetry] Clean separation between tab (public API) and tab_backend (Chrome implementation). Flat… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make unit tests pass and merge. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/inspector_console.py
diff --git a/tools/telemetry/telemetry/inspector_console.py b/tools/telemetry/telemetry/inspector_console.py
index 89811ff7b482dfd5ec41370351c3f5ef5bb9c61e..a4dd16b6f7572243df8bda351eb2af428502816b 100644
--- a/tools/telemetry/telemetry/inspector_console.py
+++ b/tools/telemetry/telemetry/inspector_console.py
@@ -5,10 +5,9 @@ import json
import logging
class InspectorConsole(object):
- def __init__(self, inspector_backend, tab):
- self._tab = tab
- self._inspector_backend = inspector_backend
- self._inspector_backend.RegisterDomain(
+ def __init__(self, tab_backend):
+ self._tab_backend = tab_backend
+ self._tab_backend.RegisterDomain(
'Console',
self._OnNotification,
self._OnClose)
@@ -35,12 +34,13 @@ class InspectorConsole(object):
def _OnClose(self):
pass
+ # False positive in PyLint 0.25.1: http://www.logilab.org/89092
@property
- def MessageOutputStream(self):
+ def message_output_stream(self): # pylint: disable=E0202
return self._message_output_stream
- @MessageOutputStream.setter
- def MessageOutputStream(self, stream):
+ @message_output_stream.setter
+ def message_output_stream(self, stream): # pylint: disable=E0202
self._message_output_stream = stream
self._UpdateConsoleEnabledState()
@@ -53,7 +53,7 @@ class InspectorConsole(object):
method_name = 'enable'
else:
method_name = 'disable'
- self._inspector_backend.SyncRequest({
+ self._tab_backend.SyncRequest({
'method': 'Console.%s' % method_name
})
self._console_enabled = enabled
« no previous file with comments | « tools/telemetry/telemetry/browser_backend.py ('k') | tools/telemetry/telemetry/inspector_console_unittest.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698