tools/telemetry/telemetry/page_runner.py - Issue 11819018: [Telemetry] Clean separation between tab (public API) and tab_backend (Chrome implementation). Flat…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/page_runner.py

Issue 11819018: [Telemetry] Clean separation between tab (public API) and tab_backend (Chrome implementation). Flat… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Make unit tests pass and merge. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: tools/telemetry/telemetry/page_runner.py

diff --git a/tools/telemetry/telemetry/page_runner.py b/tools/telemetry/telemetry/page_runner.py

index 3cfb6d4a6747ba967ed3b22274cca840c61843f0..56f6825d35294869fe4c60cd3ceddfe552b68044 100644

--- a/tools/telemetry/telemetry/page_runner.py

+++ b/tools/telemetry/telemetry/page_runner.py

@@ -28,7 +28,7 @@ class _RunState(object):

def Close(self):

if self.tab:

- self.tab.Disconnect()

+ self.tab.Close()

self.tab = None

if self.browser:

« no previous file with comments | « tools/telemetry/telemetry/inspector_timeline.py ('k') | tools/telemetry/telemetry/tab.py » ('j') | no next file with comments »