Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Unified Diff: tools/telemetry/telemetry/inspector_runtime.py

Issue 11819018: [Telemetry] Clean separation between tab (public API) and tab_backend (Chrome implementation). Flat… (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Make unit tests pass and merge. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/telemetry/telemetry/inspector_runtime.py
diff --git a/tools/telemetry/telemetry/inspector_runtime.py b/tools/telemetry/telemetry/inspector_runtime.py
index e6a90bc0ff6e105001d28ddf8e2c790d7aa9e0d3..6b27baa729cc9b83611c0e80064f189f8a90c34c 100644
--- a/tools/telemetry/telemetry/inspector_runtime.py
+++ b/tools/telemetry/telemetry/inspector_runtime.py
@@ -5,10 +5,9 @@ class EvaluateException(Exception):
pass
class InspectorRuntime(object):
- def __init__(self, inspector_backend, tab):
- self._tab = tab
- self._inspector_backend = inspector_backend
- self._inspector_backend.RegisterDomain(
+ def __init__(self, tab_backend):
+ self._tab_backend = tab_backend
+ self._tab_backend.RegisterDomain(
'Runtime',
self._OnNotification,
self._OnClose)
@@ -45,7 +44,7 @@ class InspectorRuntime(object):
'returnByValue': True
}
}
- res = self._inspector_backend.SyncRequest(request, timeout)
+ res = self._tab_backend.SyncRequest(request, timeout)
if 'error' in res:
raise EvaluateException(res['error']['message'])
« no previous file with comments | « tools/telemetry/telemetry/inspector_page_unittest.py ('k') | tools/telemetry/telemetry/inspector_timeline.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698