Issue 11618026: Move filters to RenderPassDrawQuad

Issue 11618026: Move filters to RenderPassDrawQuad (Closed)

Created:
8 years ago by piman

Modified:
8 years ago

Reviewers:
danakj, Cris Neckar

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, cc-bugs_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move filters to RenderPassDrawQuad BUG=123444 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=174466

Patch Set 4 : merge 11638020 #

Patch Set 5 : rebase #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+204 lines, -245 lines)			Patch
M	cc/delegating_renderer.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	cc/delegating_renderer.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	cc/direct_renderer.h	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	cc/direct_renderer.cc	View	1 2 3	2 chunks	+2 lines, -4 lines	0 comments	Download
M	cc/draw_quad_unittest.cc	View	1 2	3 chunks	+29 lines, -2 lines	0 comments	Download
M	cc/gl_renderer.h	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	cc/gl_renderer.cc	View	1 2 3 4	4 chunks	+5 lines, -11 lines	0 comments	Download
M	cc/gl_renderer_pixeltest.cc	View	1 2 3	3 chunks	+9 lines, -12 lines	0 comments	Download
M	cc/gl_renderer_unittest.cc	View	1 2 3 4	11 chunks	+10 lines, -18 lines	0 comments	Download
M	cc/layer_tree_host_impl.cc	View	1 2 3 4	11 chunks	+27 lines, -31 lines	0 comments	Download
M	cc/layer_tree_host_impl_unittest.cc	View	1 2 3 4	14 chunks	+21 lines, -22 lines	0 comments	Download
M	cc/render_pass.h	View	1 2 3 4	3 chunks	+3 lines, -16 lines	0 comments	Download
M	cc/render_pass.cc	View		3 chunks	+2 lines, -11 lines	0 comments	Download
M	cc/render_pass_draw_quad.h	View	1 2	4 chunks	+21 lines, -2 lines	0 comments	Download
M	cc/render_pass_draw_quad.cc	View	1 2	3 chunks	+37 lines, -25 lines	0 comments	Download
M	cc/render_pass_unittest.cc	View	1 2 3 4	5 chunks	+1 line, -18 lines	0 comments	Download
M	cc/render_surface_impl.cc	View		2 chunks	+1 line, -4 lines	0 comments	Download
M	cc/renderer.h	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	cc/scoped_ptr_vector.h	View	1 2 3	1 chunk	+1 line, -1 line	0 comments	Download
M	cc/software_renderer.cc	View	1 2 3 4	2 chunks	+1 line, -6 lines	0 comments	Download
M	cc/software_renderer_unittest.cc	View	1 2 3	3 chunks	+8 lines, -22 lines	0 comments	Download
M	cc/test/render_pass_test_common.cc	View	1 2 3 4	1 chunk	+4 lines, -1 line	0 comments	Download
M	cc/test/render_pass_test_utils.cc	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	content/common/cc_messages.h	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	content/common/cc_messages.cc	View		5 chunks	+1 line, -17 lines	0 comments	Download
M	content/common/cc_messages_unittest.cc	View		5 chunks	+9 lines, -12 lines	0 comments	Download

Messages

Total messages: 9 (0 generated)

Expand Messages | Collapse Messages

piman

danakj: please review cdn: security for cc_messages (fields move from one class to another one, ...

8 years ago (2012-12-19 21:10:08 UTC) #1

danakj

Yay! LGTM! https://codereview.chromium.org/11618026/diff/1/cc/draw_quad_unittest.cc File cc/draw_quad_unittest.cc (right): https://codereview.chromium.org/11618026/diff/1/cc/draw_quad_unittest.cc#newcode7 cc/draw_quad_unittest.cc:7: #include <public/WebFilterOperations.h> Use "third_party/WebKit/...." and stick this ...

8 years ago (2012-12-19 21:22:52 UTC) #2

piman

Patch 3 fixes the nits, patch 4 also merges 11638020 which turns out is needed ...

8 years ago (2012-12-19 21:50:00 UTC) #3

danakj

On Wed, Dec 19, 2012 at 4:50 PM, <piman@chromium.org> wrote: > Patch 3 fixes the ...

8 years ago (2012-12-19 21:51:29 UTC) #4

On Wed, Dec 19, 2012 at 4:50 PM, <piman@chromium.org> wrote:

> Patch 3 fixes the nits, patch 4 also merges 11638020 which turns out is
> needed
> for the test changes


SGTM, thanks!


>
>
>
> https://codereview.chromium.**org/11618026/diff/1/cc/draw_**
>
quad_unittest.cc<https://codereview.chromium.org/11618026/diff/1/cc/draw_quad_unittest.cc>
> File cc/draw_quad_unittest.cc (right):
>
> https://codereview.chromium.**org/11618026/diff/1/cc/draw_**
>
quad_unittest.cc#newcode7<https://codereview.chromium.org/11618026/diff/1/cc/draw_quad_unittest.cc#newcode7>
> cc/draw_quad_unittest.cc:7: #include <public/WebFilterOperations.h>
> On 2012/12/19 21:22:52, danakj wrote:
>
>> Use "third_party/WebKit/...." and stick this inline with the other
>>
> includes.
>
> Done.
>
>
> https://codereview.chromium.**org/11618026/diff/1/cc/gl_**
>
renderer_pixeltest.cc<https://codereview.chromium.org/11618026/diff/1/cc/gl_renderer_pixeltest.cc>
> File cc/gl_renderer_pixeltest.cc (right):
>
> https://codereview.chromium.**org/11618026/diff/1/cc/gl_**
>
renderer_pixeltest.cc#**newcode120<https://codereview.chromium.org/11618026/diff/1/cc/gl_renderer_pixeltest.cc#newcode120>
> cc/gl_renderer_pixeltest.cc:**120: WebKit::WebFilterOperations(),
> On 2012/12/19 21:22:52, danakj wrote:
>
>>   // foreground filter
>>
>
> Done.
>
>
> https://codereview.chromium.**org/11618026/diff/1/cc/gl_**
>
renderer_pixeltest.cc#**newcode121<https://codereview.chromium.org/11618026/diff/1/cc/gl_renderer_pixeltest.cc#newcode121>
> cc/gl_renderer_pixeltest.cc:**121: skia::RefPtr<SkImageFilter>(),
> On 2012/12/19 21:22:52, danakj wrote:
>
>>   // foreground filter
>>
>
> Done.
>
>
> https://codereview.chromium.**org/11618026/diff/1/cc/gl_**
>
renderer_pixeltest.cc#**newcode122<https://codereview.chromium.org/11618026/diff/1/cc/gl_renderer_pixeltest.cc#newcode122>
> cc/gl_renderer_pixeltest.cc:**122: WebKit::WebFilterOperations())**;
> On 2012/12/19 21:22:52, danakj wrote:
>
>>   // background filter
>>
>
> Done.
>
>
> https://codereview.chromium.**org/11618026/diff/1/cc/render_**
>
pass_draw_quad.cc<https://codereview.chromium.org/11618026/diff/1/cc/render_pass_draw_quad.cc>
> File cc/render_pass_draw_quad.cc (right):
>
> https://codereview.chromium.**org/11618026/diff/1/cc/render_**
>
pass_draw_quad.cc#newcode37<https://codereview.chromium.org/11618026/diff/1/cc/render_pass_draw_quad.cc#newcode37>
> cc/render_pass_draw_quad.cc:**37: const WebKit::WebFilterOperations&
> background_filters) {
> On 2012/12/19 21:22:52, danakj wrote:
>
>> 80 cols, i guess wrap at the SetNew(\n
>>
>
> Done.
>
>
> https://codereview.chromium.**org/11618026/diff/1/cc/render_**
>
pass_draw_quad.cc#newcode62<https://codereview.chromium.org/11618026/diff/1/cc/render_pass_draw_quad.cc#newcode62>
> cc/render_pass_draw_quad.cc:**62: const WebKit::WebFilterOperations&
> background_filters) {
> On 2012/12/19 21:22:52, danakj wrote:
>
>> 80 cols here too
>>
>
> Done.
>
>
> https://codereview.chromium.**org/11618026/diff/1/cc/render_**
>
pass_draw_quad.h<https://codereview.chromium.org/11618026/diff/1/cc/render_pass_draw_quad.h>
> File cc/render_pass_draw_quad.h (right):
>
> https://codereview.chromium.**org/11618026/diff/1/cc/render_**
>
pass_draw_quad.h#newcode8<https://codereview.chromium.org/11618026/diff/1/cc/render_pass_draw_quad.h#newcode8>
> cc/render_pass_draw_quad.h:8: #include <public/WebFilterOperations.h>
> On 2012/12/19 21:22:52, danakj wrote:
>
>> use "third_party/WebKit/..."
>>
>
> Done.
>
>
https://codereview.chromium.**org/11618026/<https://codereview.chromium.org/1...
>

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/11618026/10002

8 years ago (2012-12-21 20:08:41 UTC) #6

commit-bot: I haz the power

Commit queue rejected this change because the description was changed between the time the change ...

8 years ago (2012-12-21 22:09:39 UTC) #7

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/piman@chromium.org/11618026/10002

8 years ago (2012-12-21 22:14:47 UTC) #8

Message was sent while issue was closed.

Change committed as 174466

Expand Messages | Collapse Messages