Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(311)

Unified Diff: content/common/cc_messages_unittest.cc

Issue 11618026: Move filters to RenderPassDrawQuad (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/common/cc_messages.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/common/cc_messages_unittest.cc
diff --git a/content/common/cc_messages_unittest.cc b/content/common/cc_messages_unittest.cc
index bfcb087e134d03dc1d33273de68e6d000bc5d606..8e75d5fb6ee33c105b1f4d111f747250155c4a9f 100644
--- a/content/common/cc_messages_unittest.cc
+++ b/content/common/cc_messages_unittest.cc
@@ -43,9 +43,6 @@ class CCMessagesTest : public testing::Test {
EXPECT_EQ(a->has_transparent_background, b->has_transparent_background);
EXPECT_EQ(a->has_occlusion_from_outside_target_surface,
b->has_occlusion_from_outside_target_surface);
- EXPECT_EQ(a->filters, b->filters);
- EXPECT_EQ(a->filter, b->filter);
- EXPECT_EQ(a->background_filters, b->background_filters);
}
void Compare(const SharedQuadState* a, const SharedQuadState* b) {
@@ -130,6 +127,9 @@ class CCMessagesTest : public testing::Test {
EXPECT_EQ(a->contents_changed_since_last_frame,
b->contents_changed_since_last_frame);
EXPECT_EQ(a->mask_uv_rect.ToString(), b->mask_uv_rect.ToString());
+ EXPECT_EQ(a->filters, b->filters);
+ EXPECT_EQ(a->filter, b->filter);
+ EXPECT_EQ(a->background_filters, b->background_filters);
}
void Compare(const SolidColorDrawQuad* a, const SolidColorDrawQuad* b) {
@@ -290,7 +290,10 @@ TEST_F(CCMessagesTest, AllQuads) {
arbitrary_bool2,
arbitrary_resourceid,
arbitrary_rect1,
- arbitrary_rectf1);
+ arbitrary_rectf1,
+ arbitrary_filters1,
+ arbitrary_filter, // TODO(piman): not serialized.
+ arbitrary_filters2);
scoped_ptr<RenderPassDrawQuad> renderpass_cmp = renderpass_in->Copy(
renderpass_in->shared_quad_state, renderpass_in->render_pass_id);
@@ -355,10 +358,7 @@ TEST_F(CCMessagesTest, AllQuads) {
arbitrary_rectf1,
arbitrary_matrix,
arbitrary_bool1,
- arbitrary_bool2,
- arbitrary_filters1,
- arbitrary_filter, // TODO(danakj): filter is not serialized.
- arbitrary_filters2);
+ arbitrary_bool2);
pass_in->shared_quad_state_list.append(shared_state1_in.Pass());
pass_in->quad_list.append(checkerboard_in.PassAs<DrawQuad>());
@@ -377,10 +377,7 @@ TEST_F(CCMessagesTest, AllQuads) {
arbitrary_rectf1,
arbitrary_matrix,
arbitrary_bool1,
- arbitrary_bool2,
- arbitrary_filters1,
- arbitrary_filter, // TODO(danakj): filter is not serialized.
- arbitrary_filters2);
+ arbitrary_bool2);
pass_cmp->shared_quad_state_list.append(shared_state1_cmp.Pass());
pass_cmp->quad_list.append(checkerboard_cmp.PassAs<DrawQuad>());
« no previous file with comments | « content/common/cc_messages.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698