Add copy and assignment to FundamentalValue and StringValue.

Add copy and assignment to FundamentalValue and StringValue.

Also get rid of use of CreateStringValue in chromeos/ directory.

This is a retry of r167808, but adding the copy and assign constructors fixes a clang compile error.

BUG=160586
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=168868

[Evan Stade, 2012-11-16 23:52:33]

clang's complaint was:

C++98 requires an accessible copy constructor for class 'base::FundamentalValue'
when binding a reference to a temporary; was private
[-Werror,-Wbind-to-temporary-copy]
  SetValueProperty(prop, base::FundamentalValue(i));

FWIW, it seems this has been fixed in C++11.

[brettw, 2012-11-17 20:57:01]

lgtm

http://codereview.chromium.org/11418048/diff/2001/base/values.h
File base/values.h (right):

http://codereview.chromium.org/11418048/diff/2001/base/values.h#newcode120
base/values.h:120: void operator=(const Value& value);
This should return Value&

[Evan Stade, 2012-11-19 18:54:10]

+davemoore +stevenjb TBR (it's the same change as before)

[stevenjb, 2012-11-19 20:31:23]

lgtm

[commit-bot: I haz the power, 2012-11-20 01:08:59]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/11418048/7006

[commit-bot: I haz the power, 2012-11-20 02:18:22]

Retried try job too often for step(s) interactive_ui_tests

[commit-bot: I haz the power, 2012-11-20 18:52:25]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/estade@chromium.org/11418048/7006

[commit-bot: I haz the power, 2012-11-20 20:37:57]

Change committed as 168868