Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Unified Diff: chrome/browser/chromeos/extensions/file_browser_private_api.cc

Issue 11418048: Add copy and assignment to FundamentalValue and StringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/extensions/file_browser_private_api.cc
diff --git a/chrome/browser/chromeos/extensions/file_browser_private_api.cc b/chrome/browser/chromeos/extensions/file_browser_private_api.cc
index 3f0ee0c223ae21561ad5c6edb2f5908a9d9ea33d..1a1ac8c8cbb35fb57534237586385b0f1a42d124 100644
--- a/chrome/browser/chromeos/extensions/file_browser_private_api.cc
+++ b/chrome/browser/chromeos/extensions/file_browser_private_api.cc
@@ -1346,7 +1346,7 @@ bool AddMountFunction::RunImpl() {
}
// Set default return source path to the empty string.
- SetResult(Value::CreateStringValue(""));
+ SetResult(new base::StringValue(""));
chromeos::MountType mount_type =
DiskMountManager::MountTypeFromString(mount_type_str);
@@ -1361,7 +1361,7 @@ bool AddMountFunction::RunImpl() {
// Pass back the drive mount point path as source path.
const std::string& drive_path =
drive::util::GetDriveMountPointPathAsString();
- SetResult(Value::CreateStringValue(drive_path));
+ SetResult(new base::StringValue(drive_path));
FileBrowserEventRouterFactory::GetForProfile(profile_)->
MountDrive(base::Bind(&AddMountFunction::SendResponse,
this,
@@ -1419,7 +1419,7 @@ void AddMountFunction::OnMountedStateSet(const std::string& mount_type,
DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
DiskMountManager* disk_mount_manager = DiskMountManager::GetInstance();
// Pass back the actual source path of the mount point.
- SetResult(Value::CreateStringValue(file_path.value()));
+ SetResult(new base::StringValue(file_path.value()));
SendResponse(true);
// MountPath() takes a std::string.
disk_mount_manager->MountPath(file_path.AsUTF8Unsafe(),
@@ -2427,9 +2427,9 @@ void GetFileLocationsFunction::GetLocalPathsResponseOnUIThread(
ListValue* locations = new ListValue;
for (size_t i = 0; i < files.size(); ++i) {
if (drive::util::IsUnderDriveMountPoint(files[i].file_path)) {
- locations->Append(Value::CreateStringValue("drive"));
+ locations->Append(new base::StringValue("drive"));
} else {
- locations->Append(Value::CreateStringValue("local"));
+ locations->Append(new base::StringValue("local"));
}
}
@@ -2516,7 +2516,7 @@ void GetDriveFilesFunction::OnFileReady(
FilePath drive_path = remaining_drive_paths_.front();
if (error == drive::DRIVE_FILE_OK) {
- local_paths_->Append(Value::CreateStringValue(local_path.value()));
+ local_paths_->Append(new base::StringValue(local_path.value()));
DVLOG(1) << "Got " << drive_path.value() << " as " << local_path.value();
// TODO(benchan): If the file is a hosted document, a temporary JSON file
@@ -2525,7 +2525,7 @@ void GetDriveFilesFunction::OnFileReady(
// file_manager.js to manage the lifetime of the temporary file.
// See crosbug.com/28058.
} else {
- local_paths_->Append(Value::CreateStringValue(""));
+ local_paths_->Append(new base::StringValue(""));
DVLOG(1) << "Failed to get " << drive_path.value()
<< " with error code: " << error;
}
« no previous file with comments | « chrome/browser/chromeos/extensions/echo_private_api.cc ('k') | chrome/browser/chromeos/extensions/file_handler_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698