Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/chromeos/cros/cros_network_functions.cc

Issue 11418048: Add copy and assignment to FundamentalValue and StringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/values.cc ('k') | chrome/browser/chromeos/cros/cros_network_functions_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/chromeos/cros/cros_network_functions.cc
diff --git a/chrome/browser/chromeos/cros/cros_network_functions.cc b/chrome/browser/chromeos/cros/cros_network_functions.cc
index 54700fcfed456904a69735cff3d5b7abad1cb4e2..ea4cb80ffbd86c91bc7cc288548a9b0b8ac26731 100644
--- a/chrome/browser/chromeos/cros/cros_network_functions.cc
+++ b/chrome/browser/chromeos/cros/cros_network_functions.cc
@@ -537,16 +537,16 @@ void CrosRequestHiddenWifiNetworkProperties(
base::DictionaryValue properties;
properties.SetWithoutPathExpansion(
flimflam::kModeProperty,
- base::Value::CreateStringValue(flimflam::kModeManaged));
+ new base::StringValue(flimflam::kModeManaged));
properties.SetWithoutPathExpansion(
flimflam::kTypeProperty,
- base::Value::CreateStringValue(flimflam::kTypeWifi));
+ new base::StringValue(flimflam::kTypeWifi));
properties.SetWithoutPathExpansion(
flimflam::kSSIDProperty,
- base::Value::CreateStringValue(ssid));
+ new base::StringValue(ssid));
properties.SetWithoutPathExpansion(
flimflam::kSecurityProperty,
- base::Value::CreateStringValue(security));
+ new base::StringValue(security));
// shill.Manger.GetService() will apply the property changes in
// |properties| and return a new or existing service to OnGetService().
// OnGetService will then call GetProperties which will then call callback.
@@ -563,20 +563,20 @@ void CrosRequestVirtualNetworkProperties(
base::DictionaryValue properties;
properties.SetWithoutPathExpansion(
flimflam::kTypeProperty,
- base::Value::CreateStringValue(flimflam::kTypeVPN));
+ new base::StringValue(flimflam::kTypeVPN));
properties.SetWithoutPathExpansion(
flimflam::kProviderNameProperty,
- base::Value::CreateStringValue(service_name));
+ new base::StringValue(service_name));
properties.SetWithoutPathExpansion(
flimflam::kProviderHostProperty,
- base::Value::CreateStringValue(server_hostname));
+ new base::StringValue(server_hostname));
properties.SetWithoutPathExpansion(
flimflam::kProviderTypeProperty,
- base::Value::CreateStringValue(provider_type));
+ new base::StringValue(provider_type));
// The actual value of Domain does not matter, so just use service_name.
properties.SetWithoutPathExpansion(
flimflam::kVPNDomainProperty,
- base::Value::CreateStringValue(service_name));
+ new base::StringValue(service_name));
// shill.Manger.GetService() will apply the property changes in
// |properties| and pass a new or existing service to OnGetService().
« no previous file with comments | « base/values.cc ('k') | chrome/browser/chromeos/cros/cros_network_functions_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698