Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1000)

Unified Diff: chrome/browser/chromeos/settings/cros_settings_unittest.cc

Issue 11418048: Add copy and assignment to FundamentalValue and StringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: . Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/settings/cros_settings_unittest.cc
diff --git a/chrome/browser/chromeos/settings/cros_settings_unittest.cc b/chrome/browser/chromeos/settings/cros_settings_unittest.cc
index e3fc928b7b06ae90308b887d0b72d449a2afa46c..fe76ec38c06d574b991c06a37218c5b57f12f4e2 100644
--- a/chrome/browser/chromeos/settings/cros_settings_unittest.cc
+++ b/chrome/browser/chromeos/settings/cros_settings_unittest.cc
@@ -119,7 +119,7 @@ TEST_F(CrosSettingsTest, SetWhitelist) {
// Setting the whitelist should also switch the value of
// kAccountsPrefAllowNewUser to false.
base::ListValue whitelist;
- whitelist.Append(base::Value::CreateStringValue("me@owner"));
+ whitelist.Append(new base::StringValue("me@owner"));
AddExpectation(kAccountsPrefAllowNewUser,
base::Value::CreateBooleanValue(false));
AddExpectation(kAccountsPrefUsers, whitelist.DeepCopy());
@@ -179,7 +179,7 @@ TEST_F(CrosSettingsTest, SetWhitelistAndNoNewUsers) {
// Setting the whitelist should allow us to set kAccountsPrefAllowNewUser to
// false (which is the implicit value too).
base::ListValue whitelist;
- whitelist.Append(base::Value::CreateStringValue("me@owner"));
+ whitelist.Append(new base::StringValue("me@owner"));
AddExpectation(kAccountsPrefUsers, whitelist.DeepCopy());
AddExpectation(kAccountsPrefAllowNewUser,
base::Value::CreateBooleanValue(false));
@@ -209,10 +209,10 @@ TEST_F(CrosSettingsTest, SetEphemeralUsersEnabled) {
TEST_F(CrosSettingsTest, FindEmailInList) {
base::ListValue list;
- list.Append(base::Value::CreateStringValue("user@example.com"));
- list.Append(base::Value::CreateStringValue("nodomain"));
- list.Append(base::Value::CreateStringValue("with.dots@gmail.com"));
- list.Append(base::Value::CreateStringValue("Upper@example.com"));
+ list.Append(new base::StringValue("user@example.com"));
+ list.Append(new base::StringValue("nodomain"));
+ list.Append(new base::StringValue("with.dots@gmail.com"));
+ list.Append(new base::StringValue("Upper@example.com"));
CrosSettings* cs = &settings_;
cs->Set(kAccountsPrefUsers, list);
« no previous file with comments | « chrome/browser/chromeos/proxy_cros_settings_parser.cc ('k') | chrome/browser/chromeos/settings/device_settings_provider.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698