chrome/browser/chromeos/cros/network_ui_data_unittest.cc - Issue 11418048: Add copy and assignment to FundamentalValue and StringValue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/cros/network_ui_data_unittest.cc

Issue 11418048: Add copy and assignment to FundamentalValue and StringValue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: . Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/cros/network_ui_data_unittest.cc

diff --git a/chrome/browser/chromeos/cros/network_ui_data_unittest.cc b/chrome/browser/chromeos/cros/network_ui_data_unittest.cc

index 3f5a24a88549048c8764f21a49eb72f26b831a53..6a3440613ff0f0c93357123438192652ed7cb99a 100644

--- a/chrome/browser/chromeos/cros/network_ui_data_unittest.cc

+++ b/chrome/browser/chromeos/cros/network_ui_data_unittest.cc

@@ -127,9 +127,9 @@ TEST_F(NetworkUIDataTest, ParseOncProperty) {

onc.Set("a.a", val_a_a.DeepCopy());

onc.Set("a.b", val_a_b.DeepCopy());

base::ListValue recommended;

- recommended.Append(base::Value::CreateStringValue("b"));

- recommended.Append(base::Value::CreateStringValue("c"));

- recommended.Append(base::Value::CreateStringValue("a.a"));

+ recommended.Append(new base::StringValue("b"));

+ recommended.Append(new base::StringValue("c"));

+ recommended.Append(new base::StringValue("a.a"));

onc.Set("Recommended", recommended.DeepCopy());

onc.Set("a.Recommended", recommended.DeepCopy());