Issue 10974015: Hiding getElement* methods on ShadowRoot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10974015: Hiding getElement* methods on ShadowRoot. (Closed)

Created:
8 years, 3 months ago by blois

Modified:
8 years, 2 months ago

Reviewers:
vsm

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Hiding getElement* methods on ShadowRoot. BUG=3831 Committed: https://code.google.com/p/dart/source/detail?r=12858

Patch Set 2 : Incorporating review feedback. #

Created: 8 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -22 lines)			Patch
M	lib/html/dart2js/html_dart2js.dart	View		2 chunks	+6 lines, -11 lines	0 comments	Download
M	lib/html/dartium/html_dartium.dart	View		2 chunks	+6 lines, -11 lines	0 comments	Download
M	lib/html/scripts/htmlrenamer.py	View	1	2 chunks	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

vsm

https://chromiumcodereview.appspot.com/10974015/diff/1/lib/html/dartium/html_dartium.dart File lib/html/dartium/html_dartium.dart (left): https://chromiumcodereview.appspot.com/10974015/diff/1/lib/html/dartium/html_dartium.dart#oldcode34302 lib/html/dartium/html_dartium.dart:34302: NodeList getElementsByTagNameNS(String namespaceURI, String localName); Shouldn't we hide this ...

8 years, 3 months ago (2012-09-24 22:22:44 UTC) #1

blois

8 years, 2 months ago (2012-09-24 22:45:36 UTC) #2

lgtm

Expand Messages | Collapse Messages

Issue 10974015: Hiding getElement* methods on ShadowRoot. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Incorporating review feedback. #

Messages