lib/html/dartium/html_dartium.dart - Issue 10974015: Hiding getElement* methods on ShadowRoot.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: lib/html/dartium/html_dartium.dart

Side-by-side diff isn't available for this file because of its large size.

Issue 10974015: Hiding getElement* methods on ShadowRoot. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: lib/html/dartium/html_dartium.dart

diff --git a/lib/html/dartium/html_dartium.dart b/lib/html/dartium/html_dartium.dart

index cd835f90f579d4cd3d7563de51b971ab145b2dbf..b2a05f6b80ff4bbe237f63982ad045a6188b2158 100644

--- a/lib/html/dartium/html_dartium.dart

+++ b/lib/html/dartium/html_dartium.dart

@@ -34290,13 +34290,13 @@ abstract class ShadowRoot implements DocumentFragment {

Node clone(bool deep);

/** @domName ShadowRoot.getElementById */

- Element getElementById(String elementId);

+ Element $dom_getElementById(String elementId);

/** @domName ShadowRoot.getElementsByClassName */

- NodeList getElementsByClassName(String className);

+ NodeList $dom_getElementsByClassName(String className);

/** @domName ShadowRoot.getElementsByTagName */

- NodeList getElementsByTagName(String tagName);

+ NodeList $dom_getElementsByTagName(String tagName);

/** @domName ShadowRoot.getElementsByTagNameNS */

NodeList getElementsByTagNameNS(String namespaceURI, String localName);

vsm 2012/09/24 22:22:44 Shouldn't we hide this too?

blois 2012/09/24 22:45:36 Yes, I had originally thought that was special, bu

@@ -34328,11 +34328,11 @@ class _ShadowRootImpl extends _DocumentFragmentImpl implements ShadowRoot {

Node clone(bool deep) native "ShadowRoot_cloneNode_Callback";

- Element getElementById(String elementId) native "ShadowRoot_getElementById_Callback";

+ Element $dom_getElementById(String elementId) native "ShadowRoot_getElementById_Callback";

- NodeList getElementsByClassName(String className) native "ShadowRoot_getElementsByClassName_Callback";

+ NodeList $dom_getElementsByClassName(String className) native "ShadowRoot_getElementsByClassName_Callback";

- NodeList getElementsByTagName(String tagName) native "ShadowRoot_getElementsByTagName_Callback";

+ NodeList $dom_getElementsByTagName(String tagName) native "ShadowRoot_getElementsByTagName_Callback";

NodeList getElementsByTagNameNS(String namespaceURI, String localName) native "ShadowRoot_getElementsByTagNameNS_Callback";

« no previous file with comments | « lib/html/dart2js/html_dart2js.dart ('k') | lib/html/scripts/htmlrenamer.py » ('j') | no next file with comments »