Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(394)

Unified Diff: lib/html/dart2js/html_dart2js.dart

Issue 10974015: Hiding getElement* methods on ShadowRoot. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Incorporating review feedback. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
« no previous file with comments | « no previous file | lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/dart2js/html_dart2js.dart
diff --git a/lib/html/dart2js/html_dart2js.dart b/lib/html/dart2js/html_dart2js.dart
index 38502c327c3be27ca2c59878971d442825743e82..abcbe55e27e5fefd010dfb71156b0376abf17541 100644
--- a/lib/html/dart2js/html_dart2js.dart
+++ b/lib/html/dart2js/html_dart2js.dart
@@ -31518,16 +31518,13 @@ abstract class ShadowRoot implements DocumentFragment {
Node clone(bool deep);
/** @domName ShadowRoot.getElementById */
- Element getElementById(String elementId);
+ Element $dom_getElementById(String elementId);
/** @domName ShadowRoot.getElementsByClassName */
- NodeList getElementsByClassName(String className);
+ NodeList $dom_getElementsByClassName(String className);
/** @domName ShadowRoot.getElementsByTagName */
- NodeList getElementsByTagName(String tagName);
-
- /** @domName ShadowRoot.getElementsByTagNameNS */
- NodeList getElementsByTagNameNS(String namespaceURI, String localName);
+ NodeList $dom_getElementsByTagName(String tagName);
/** @domName ShadowRoot.getSelection */
DOMSelection getSelection();
@@ -31545,13 +31542,11 @@ class _ShadowRootImpl extends _DocumentFragmentImpl implements ShadowRoot native
_NodeImpl clone(bool deep) native "cloneNode";
- _ElementImpl getElementById(String elementId) native;
-
- _NodeListImpl getElementsByClassName(String className) native;
+ _ElementImpl $dom_getElementById(String elementId) native "getElementById";
- _NodeListImpl getElementsByTagName(String tagName) native;
+ _NodeListImpl $dom_getElementsByClassName(String className) native "getElementsByClassName";
- _NodeListImpl getElementsByTagNameNS(String namespaceURI, String localName) native;
+ _NodeListImpl $dom_getElementsByTagName(String tagName) native "getElementsByTagName";
_DOMSelectionImpl getSelection() native;
}
« no previous file with comments | « no previous file | lib/html/dartium/html_dartium.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698