Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(545)

Unified Diff: lib/html/scripts/htmlrenamer.py

Issue 10974015: Hiding getElement* methods on ShadowRoot. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Incorporating review feedback. Created 8 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/html/dartium/html_dartium.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/html/scripts/htmlrenamer.py
diff --git a/lib/html/scripts/htmlrenamer.py b/lib/html/scripts/htmlrenamer.py
index c3497179b1c677cb8010e0f8e9e65a5733f56646..d0c5d56bb5344b17fc3ef344cad05261d25a29a0 100644
--- a/lib/html/scripts/htmlrenamer.py
+++ b/lib/html/scripts/htmlrenamer.py
@@ -81,6 +81,9 @@ _private_html_members = set([
"Node.nodeType",
'Node.removeChild',
'Node.replaceChild',
+ 'ShadowRoot.getElementById',
+ 'ShadowRoot.getElementsByClassName',
+ 'ShadowRoot.getElementsByTagName',
'Storage.length',
'Storage.clear',
'Storage.getItem',
@@ -265,6 +268,7 @@ _removed_html_members = set([
"Node.get:nodeName",
"Node.lookupPrefix",
"Node.get:PROCESSING_INSTRUCTION_NODE",
+ 'ShadowRoot.getElementsByTagNameNS',
"IFrameElement.get:contentDocument",
"Window.get:frameElement",
])
« no previous file with comments | « lib/html/dartium/html_dartium.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698