Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Issue 10874034: Remove the llvm.nacl.thread.stack.padding intrinsic (Closed)

Created:
8 years, 4 months ago by Mark Seaborn
Modified:
8 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
http://git.chromium.org/native_client/pnacl-llvm.git@master
Visibility:
Public.

Description

Remove the llvm.nacl.thread.stack.padding intrinsic This intrinsic is no longer used by untrusted code's libpthread. Instead the system (the IRT and/or TCB) is responsible for aligning the stack in new threads. BUG=http://code.google.com/p/nativeclient/issues/detail?id=2904 TEST=run_stack_alignment_test Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-llvm.git;a=commit;h=745ca5f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -46 lines) Patch
M include/llvm/CodeGen/ISDOpcodes.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/llvm/Intrinsics.td View 1 chunk +0 lines, -3 lines 0 comments Download
M lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M lib/CodeGen/SelectionDAG/SelectionDAGDumper.cpp View 1 chunk +0 lines, -1 line 0 comments Download
M lib/Target/ARM/ARMISelLowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M lib/Target/ARM/ARMISelLowering.cpp View 3 chunks +0 lines, -12 lines 0 comments Download
M lib/Target/Mips/MipsISelLowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M lib/Target/Mips/MipsISelLowering.cpp View 3 chunks +0 lines, -8 lines 0 comments Download
M lib/Target/X86/X86ISelLowering.h View 1 chunk +0 lines, -1 line 0 comments Download
M lib/Target/X86/X86ISelLowering.cpp View 3 chunks +0 lines, -13 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Mark Seaborn
This is my first PNaCl-LLVM change. Are there trybots I can run this through?
8 years, 4 months ago (2012-08-23 18:12:53 UTC) #1
Derek Schuff
On 2012/08/23 18:12:53, Mark Seaborn wrote: > This is my first PNaCl-LLVM change. Are there ...
8 years, 4 months ago (2012-08-23 20:54:50 UTC) #2
Derek Schuff
lgtm I've added you to nacl-pnacl-committers in gerrit, so git-cl should just be able to ...
8 years, 4 months ago (2012-08-23 22:49:22 UTC) #3
Derek Schuff
8 years, 4 months ago (2012-08-23 22:49:45 UTC) #4
thanks for taking care of this btw.

On 2012/08/23 22:49:22, dschuff wrote:
> lgtm
> 
> I've added you to nacl-pnacl-committers in gerrit, so git-cl should just be
able
> to push this change in its usual way.

Powered by Google App Engine
This is Rietveld 408576698