Issue 10824411: Issue 4539. Tweaks for old/new spec compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10824411: Issue 4539. Tweaks for old/new spec compatibility (Closed)

Created:
8 years, 4 months ago by scheglov

Modified:
8 years, 4 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Issue 4539. Tweaks for old/new spec compatibility Temporary disables check for underscore in named optional parameters. There are not way to know if user means old or new syntax. Also makes "final" and "const" local variables a constant expressions. R=brianwilkerson@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=11117

Patch Set 1 #

Created: 8 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+49 lines, -24 lines)			Patch
M	compiler/java/com/google/dart/compiler/DartCompiler.java	View	1 chunk	+15 lines, -19 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java	View	1 chunk	+6 lines, -0 lines	0 comments	Download
M	compiler/java/com/google/dart/compiler/resolver/ResolveVisitor.java	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java	View	1 chunk	+9 lines, -2 lines	0 comments	Download
M	compiler/javatests/com/google/dart/compiler/type/TypeAnalyzerCompilerTest.java	View	1 chunk	+13 lines, -0 lines	0 comments	Download
M	tests/co19/co19-compiler.status	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/language/language.status	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages