compiler/java/com/google/dart/compiler/resolver/ResolveVisitor.java - Issue 10824411: Issue 4539. Tweaks for old/new spec compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/ResolveVisitor.java

Issue 10824411: Issue 4539. Tweaks for old/new spec compatibility (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java ('k') | compiler/javatests/com/google/dart/compiler/resolver/CompileTimeConstantTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/ResolveVisitor.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/ResolveVisitor.java b/compiler/java/com/google/dart/compiler/resolver/ResolveVisitor.java

index d47f83256970a5dbf12dbec8f069a9046c486ad5..4ddaec1bb22b4abce84e8f9b1f4da7baaa62af2d 100644

--- a/compiler/java/com/google/dart/compiler/resolver/ResolveVisitor.java

+++ b/compiler/java/com/google/dart/compiler/resolver/ResolveVisitor.java

@@ -12,6 +12,7 @@ import com.google.dart.compiler.ast.DartFunctionTypeAlias;

import com.google.dart.compiler.ast.DartIdentifier;

import com.google.dart.compiler.ast.DartNode;

import com.google.dart.compiler.ast.DartParameter;

+import com.google.dart.compiler.ast.DartThisExpression;

import com.google.dart.compiler.ast.DartTypeNode;

import com.google.dart.compiler.ast.DartTypeParameter;

import com.google.dart.compiler.type.DynamicType;

@@ -52,7 +53,7 @@ abstract class ResolveVisitor extends ASTVisitor<Element> {

element.getParameters(), returnType);

Elements.setType(element, type);

for (DartParameter parameter : node.getParameters()) {

- if (//!(parameter.getQualifier() instanceof DartThisExpression) &&

+ if (!(parameter.getQualifier() instanceof DartThisExpression) &&

parameter.getModifiers().isNamed() &&

DartIdentifier.isPrivateName(parameter.getElement().getName())) {

getContext().onError(parameter.getName(),