Issue 4539. Tweaks for old/new spec compatibility

compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 package com.google.dart.compiler.resolver;
 
 import com.google.common.base.Joiner;
 import com.google.dart.compiler.DartCompilationError;
 import com.google.dart.compiler.ErrorCode;
 import com.google.dart.compiler.ast.DartClass;
@@ skipping 1440 matching lines @@
         "interface int {}",
         "method() {",
         "  outer: for(int i = 0; i < 1; i++) {",
         "    outer();",
         "  }",
         "}"),
         errEx(ResolverErrorCode.CANNOT_RESOLVE_METHOD, 5, 5, 5));
   }
 
   public void testUndercoreInNamedParameterMethodDefinition() {
+    // TODO(scheglov)
+    // Language change 4288 adds new syntax for optional named parameters.
+    // However before "remove old optional parameter syntax" we have to support old syntax too.
+    // And this conflicts with "_" handling in optional named parameters.
+    // 
+    // http://code.google.com/p/dart/issues/detail?id=4539
+    // requested to disable this
     resolveAndTest(Joiner.on("\n").join(
         "class Object {}",
         "method([_foo]) {}",
         "class Foo {",
         "  var _bar;",
-        "  Foo([this._bar]){}",
+        "  //Foo([this._bar]){}",
         "  method([_foo]){}",
         "}"),
         errEx(ResolverErrorCode.NAMED_PARAMETERS_CANNOT_START_WITH_UNDER, 2, 9, 4),
-        errEx(ResolverErrorCode.NAMED_PARAMETERS_CANNOT_START_WITH_UNDER, 5, 8, 9),
+//        errEx(ResolverErrorCode.NAMED_PARAMETERS_CANNOT_START_WITH_UNDER, 5, 8, 9),
         errEx(ResolverErrorCode.NAMED_PARAMETERS_CANNOT_START_WITH_UNDER, 6, 11, 4));
   }
 
   public void testUndercoreInNamedParameterFunctionDefinition() {
     resolveAndTest(Joiner.on("\n").join(
         "class Object {}",
         "var f = func([_foo]) {};"),
         errEx(ResolverErrorCode.NAMED_PARAMETERS_CANNOT_START_WITH_UNDER, 2, 15, 4));
   }
 
@@ skipping 286 matching lines @@
         "class Object {}",
         "class A {",
         "  A(arg) {}",
         "}",
         "class B extends A {",
         "  B() { }",
         "}"),
         errEx(ResolverErrorCode.TOO_FEW_ARGUMENTS_IN_IMPLICIT_SUPER, 6, 3, 7));
   }
 }