compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java - Issue 10824411: Issue 4539. Tweaks for old/new spec compatibility

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java

Issue 10824411: Issue 4539. Tweaks for old/new spec compatibility (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Created 8 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « compiler/java/com/google/dart/compiler/DartCompiler.java ('k') | compiler/java/com/google/dart/compiler/resolver/ResolveVisitor.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java

diff --git a/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java b/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java

index 2691980e033b94d1d858a65aa039e8a0ca2c5874..8347f42a93b1cd2540e05c42046d324bb7860ed8 100644

--- a/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java

+++ b/compiler/java/com/google/dart/compiler/resolver/CompileTimeConstantAnalyzer.java

@@ -411,6 +411,12 @@ public class CompileTimeConstantAnalyzer {

rememberInferredType(x, inferredType);

break;

+ case VARIABLE:

+ if (!element.getModifiers().isConstant() && !element.getModifiers().isFinal()) {

+ expectedConstant(x);

+ }

+ return null;

case METHOD:

if (!element.getModifiers().isStatic() && !Elements.isTopLevel(element)) {