Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java

Issue 10824411: Issue 4539. Tweaks for old/new spec compatibility (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 8 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
diff --git a/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java b/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
index 900517c1412df5ee02eb390d2d563c98e2d0c0f3..3afded79b07d152c9fe67176ef7df5c780852484 100644
--- a/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
+++ b/compiler/javatests/com/google/dart/compiler/resolver/ResolverTest.java
@@ -1458,16 +1458,23 @@ public class ResolverTest extends ResolverTestCase {
}
public void testUndercoreInNamedParameterMethodDefinition() {
+ // TODO(scheglov)
+ // Language change 4288 adds new syntax for optional named parameters.
+ // However before "remove old optional parameter syntax" we have to support old syntax too.
+ // And this conflicts with "_" handling in optional named parameters.
+ //
+ // http://code.google.com/p/dart/issues/detail?id=4539
+ // requested to disable this
resolveAndTest(Joiner.on("\n").join(
"class Object {}",
"method([_foo]) {}",
"class Foo {",
" var _bar;",
- " Foo([this._bar]){}",
+ " //Foo([this._bar]){}",
" method([_foo]){}",
"}"),
errEx(ResolverErrorCode.NAMED_PARAMETERS_CANNOT_START_WITH_UNDER, 2, 9, 4),
- errEx(ResolverErrorCode.NAMED_PARAMETERS_CANNOT_START_WITH_UNDER, 5, 8, 9),
+// errEx(ResolverErrorCode.NAMED_PARAMETERS_CANNOT_START_WITH_UNDER, 5, 8, 9),
errEx(ResolverErrorCode.NAMED_PARAMETERS_CANNOT_START_WITH_UNDER, 6, 11, 4));
}

Powered by Google App Engine
This is Rietveld 408576698