Rename XMLHttpRequest to HttpRequest.

Rename XMLHttpRequest to HttpRequest.
Committed: https://code.google.com/p/dart/source/detail?r=11070

[sra1, 2012-08-16 19:10:32]

Looks good - lets switch to a renaming map now rather than later.

https://chromiumcodereview.appspot.com/10823352/diff/7002/lib/dom/scripts/htm...
File lib/dom/scripts/htmlrenamer.py (right):

https://chromiumcodereview.appspot.com/10823352/diff/7002/lib/dom/scripts/htm...
lib/dom/scripts/htmlrenamer.py:281: elif interface.id.startswith('XML') and
interface.id != 'XMLSerializer':
I'd much prefer an explicit test.
We are really changing 'XMLHttp' -> 'Http', not dropping 'XML'.  If some new
class comes along that begins with XML it could be renamed by accident.

I think we should replace _html_strip_webkit_prefix_classes at this time with

_html_interface_renames = {
  'DOMWindow': 'Window',
  'WebKitAnimation': 'Animation',
  ...
  'XMLHttpRequest': 'HttpRequest',
}

[Emily Fortuna, 2012-08-16 20:11:24]

PTAL. Also, added some other files from the repo that were calling
XMLHttpRequest

https://chromiumcodereview.appspot.com/10823352/diff/7002/lib/dom/scripts/htm...
File lib/dom/scripts/htmlrenamer.py (right):

https://chromiumcodereview.appspot.com/10823352/diff/7002/lib/dom/scripts/htm...
lib/dom/scripts/htmlrenamer.py:281: elif interface.id.startswith('XML') and
interface.id != 'XMLSerializer':
On 2012/08/16 19:10:33, sra1 wrote:
> I'd much prefer an explicit test.
> We are really changing 'XMLHttp' -> 'Http', not dropping 'XML'.  If some new
> class comes along that begins with XML it could be renamed by accident.
> 
> I think we should replace _html_strip_webkit_prefix_classes at this time with
> 
> _html_interface_renames = {
>   'DOMWindow': 'Window',
>   'WebKitAnimation': 'Animation',
>   ...
>   'XMLHttpRequest': 'HttpRequest',
> }

Done.

[sra1, 2012-08-16 20:20:36]

lgtm

https://chromiumcodereview.appspot.com/10823352/diff/41/lib/dom/scripts/htmlr...
File lib/dom/scripts/htmlrenamer.py (right):

https://chromiumcodereview.appspot.com/10823352/diff/41/lib/dom/scripts/htmlr...
lib/dom/scripts/htmlrenamer.py:281: elif interface.id in
_html_interface_renames.keys():
drop ".keys()", 'in' works directly