Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(10)

Issue 10823352: Rename XMLHttpRequest to HttpRequest. (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
4 years, 11 months ago by Emily Fortuna
Modified:
4 years, 11 months ago
Reviewers:
vsm, sra1
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rename XMLHttpRequest to HttpRequest. Committed: https://code.google.com/p/dart/source/detail?r=11070

Patch Set 1 : #

Total comments: 2

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+599 lines, -668 lines) Patch
M editor/tools/plugins/com.google.dart.tools.debug.core/src/com/google/dart/tools/debug/core/util/agent.html View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/dom/scripts/htmlrenamer.py View 1 2 chunks +21 lines, -19 lines 1 comment Download
A + lib/dom/src/_HttpRequestUtils.dart View 1 chunk +6 lines, -6 lines 0 comments Download
D lib/dom/src/_XMLHttpRequestUtils.dart View 1 chunk +0 lines, -28 lines 0 comments Download
A + lib/dom/templates/html/dart2js/factoryprovider_HttpRequest.darttemplate View 1 chunk +7 lines, -7 lines 0 comments Download
D lib/dom/templates/html/dart2js/factoryprovider_XMLHttpRequest.darttemplate View 1 chunk +0 lines, -15 lines 0 comments Download
M lib/dom/templates/html/dart2js/html_dart2js.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
A + lib/dom/templates/html/dartium/factoryprovider_HttpRequest.darttemplate View 1 chunk +6 lines, -6 lines 0 comments Download
D lib/dom/templates/html/dartium/factoryprovider_XMLHttpRequest.darttemplate View 1 chunk +0 lines, -16 lines 0 comments Download
M lib/dom/templates/html/dartium/html_dartium.darttemplate View 1 chunk +1 line, -1 line 0 comments Download
A + lib/dom/templates/html/interface/interface_HttpRequest.darttemplate View 0 chunks +-1 lines, --1 lines 0 comments Download
D lib/dom/templates/html/interface/interface_XMLHttpRequest.darttemplate View 1 chunk +0 lines, -12 lines 0 comments Download
M lib/html/dart2js/html_dart2js.dart View 7 chunks +324 lines, -324 lines 0 comments Download
M lib/html/dartium/html_dartium.dart View 10 chunks +209 lines, -209 lines 0 comments Download
M pkg/dartdoc/client-live-nav.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M samples/chat/dart_client/chat.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M samples/leap/request_cache.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M samples/newissues/newissues.dart View 1 1 chunk +4 lines, -4 lines 0 comments Download
M samples/swarm/DataSource.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M samples/ui_lib/base/Env.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M samples/webcomponents/shadow_polyfill.dart View 1 2 chunks +2 lines, -2 lines 0 comments Download
M tests/html/event_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/html/xhr_cross_origin_test.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M tests/html/xhr_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
Trybot results:
Commit queue not available (can’t edit this change).

Messages

Total messages: 4 (0 generated)
Emily Fortuna
4 years, 11 months ago (2012-08-16 18:41:24 UTC) #1
sra1
Looks good - lets switch to a renaming map now rather than later. https://chromiumcodereview.appspot.com/10823352/diff/7002/lib/dom/scripts/htmlrenamer.py File ...
4 years, 11 months ago (2012-08-16 19:10:32 UTC) #2
Emily Fortuna
PTAL. Also, added some other files from the repo that were calling XMLHttpRequest https://chromiumcodereview.appspot.com/10823352/diff/7002/lib/dom/scripts/htmlrenamer.py File ...
4 years, 11 months ago (2012-08-16 20:11:24 UTC) #3
sra1
4 years, 11 months ago (2012-08-16 20:20:36 UTC) #4
lgtm

https://chromiumcodereview.appspot.com/10823352/diff/41/lib/dom/scripts/htmlr...
File lib/dom/scripts/htmlrenamer.py (right):

https://chromiumcodereview.appspot.com/10823352/diff/41/lib/dom/scripts/htmlr...
lib/dom/scripts/htmlrenamer.py:281: elif interface.id in
_html_interface_renames.keys():
drop ".keys()", 'in' works directly
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld a45af40d5