Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Issue 10790077: Add tzcnt as an acceptable instruction to x86-64 validator (it already (Closed)

Created:
8 years, 5 months ago by Karl
Modified:
8 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Visibility:
Public.

Description

Add tzcnt as an acceptable instruction to x86-64 validator (it already handled lzcnt). BUG= http://code.google.com/p/nativeclient/issues/detail?id=2869 Committed: https://src.chromium.org/viewvc/native_client?view=rev&revision=9278

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1565 lines, -1530 lines) Patch
M src/trusted/validator/x86/decoder/gen/nc_opcode_table_32.h View 1 20 chunks +748 lines, -744 lines 0 comments Download
M src/trusted/validator/x86/decoder/gen/nc_opcode_table_64.h View 1 20 chunks +756 lines, -752 lines 0 comments Download
M src/trusted/validator/x86/decoder/gen/ncopcode_insts.h View 1 1 chunk +23 lines, -22 lines 0 comments Download
M src/trusted/validator/x86/decoder/gen/ncopcode_insts_impl.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/trusted/validator/x86/decoder/gen/ncval_reg_sfi_opcode_table_32.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/trusted/validator/x86/decoder/gen/ncval_reg_sfi_opcode_table_64.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M src/trusted/validator/x86/decoder/generator/ncdecode_sse.c View 1 1 chunk +11 lines, -2 lines 1 comment Download
M src/trusted/validator/x86/decoder/generator/testdata/32/modeled_insts.txt View 1 1 chunk +5 lines, -2 lines 0 comments Download
M src/trusted/validator/x86/decoder/generator/testdata/64/modeled_insts.txt View 1 1 chunk +5 lines, -2 lines 0 comments Download
M src/trusted/validator/x86/decoder/generator/testdata/64/ncval_reg_sfi_modeled_insts.txt View 1 1 chunk +5 lines, -2 lines 0 comments Download
M src/trusted/validator/x86/decoder/ncopcode_insts.enum View 1 1 chunk +1 line, -0 lines 0 comments Download
A src/trusted/validator_x86/testdata/64/lzcnt.dis View 1 chunk +1 line, -0 lines 0 comments Download
A src/trusted/validator_x86/testdata/64/lzcnt.hex View 1 chunk +2 lines, -0 lines 0 comments Download
A src/trusted/validator_x86/testdata/64/tzcnt.dis View 1 chunk +1 line, -0 lines 0 comments Download
A src/trusted/validator_x86/testdata/64/tzcnt.hex View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Karl
8 years, 5 months ago (2012-07-19 19:29:58 UTC) #1
Karl
Need to change lzcnt and tzcnt to work as 386-instruction. See comments by Roland on ...
8 years, 5 months ago (2012-07-24 21:03:02 UTC) #2
Karl
http://codereview.chromium.org/10790077/diff/10004/src/trusted/validator/x86/decoder/generator/ncdecode_sse.c File src/trusted/validator/x86/decoder/generator/ncdecode_sse.c (right): http://codereview.chromium.org/10790077/diff/10004/src/trusted/validator/x86/decoder/generator/ncdecode_sse.c#newcode337 src/trusted/validator/x86/decoder/generator/ncdecode_sse.c:337: NaClDefine(" f30fbc: Tzcnt $Gv, $Ev", NACLi_386, st, Move); Made ...
8 years, 5 months ago (2012-07-24 21:28:18 UTC) #3
Karl
Is anyone reviewing this CL?
8 years, 5 months ago (2012-07-26 19:31:25 UTC) #4
Brad Chen
Oops; I'll have a look today. On Thu, Jul 26, 2012 at 12:31 PM, <kschimpf@google.com> ...
8 years, 5 months ago (2012-07-26 19:40:19 UTC) #5
Brad Chen
LGTM Why is it that the production 32-bit validator doens't need this fix?
8 years, 5 months ago (2012-07-26 19:44:38 UTC) #6
Karl
8 years, 5 months ago (2012-07-26 19:48:21 UTC) #7
The fix for the 32-bit version is a separate CL.

Powered by Google App Engine
This is Rietveld 408576698