src/trusted/validator/x86/decoder/generator/ncdecode_sse.c - Issue 10790077: Add tzcnt as an acceptable instruction to x86-64 validator (it already

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/trusted/validator/x86/decoder/generator/ncdecode_sse.c

Issue 10790077: Add tzcnt as an acceptable instruction to x86-64 validator (it already (Closed) Base URL: svn://svn.chromium.org/native_client/trunk/src/native_client/

Patch Set: Created 8 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « src/trusted/validator/x86/decoder/gen/ncval_reg_sfi_opcode_table_64.h ('k') | src/trusted/validator/x86/decoder/generator/testdata/32/modeled_insts.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: src/trusted/validator/x86/decoder/generator/ncdecode_sse.c

===================================================================

--- src/trusted/validator/x86/decoder/generator/ncdecode_sse.c (revision 9237)

+++ src/trusted/validator/x86/decoder/generator/ncdecode_sse.c (working copy)

@@ -329,8 +329,17 @@

NaClDefine(" f30f7f: Movdqu $Wdq, $Vdq", NACLi_SSE2, st, Move);

NaClDefIter(" f20fb8+@i: Invalid", 0, 7, NACLi_INVALID, st, Other);

NaClDefine(" f30fb8: Popcnt $Gv, $Ev", NACLi_POPCNT, st, Move);

- NaClDefIter(" f30fb9+@i: Invalid", 0, 3, NACLi_INVALID, st, Other);

- NaClDefine(" f30fbd: Lzcnt $Gv, $Ev", NACLi_LZCNT, st, Move);

+ NaClDefIter(" f30fb9+@i: Invalid", 0, 2, NACLi_INVALID, st, Other);

+ /* tzcnt is treated as a bsf on machines that don't have tzcnt.

+ * Hence, even though its conditional on NACLi_LZCNT, we act

+ * like it can be used on all processors.

+ */

+ NaClDefine(" f30fbc: Tzcnt $Gv, $Ev", NACLi_386, st, Move);

Karl 2012/07/24 21:28:18 Made tzcnt and lzcnt work on all processors.

+ /* lzcnt is treated as a bsr on machines that don't have lzcnt.

+ * Hence, even though its conditional on NACLi_LZCNT, we act

+ * like it can be used on all processors.

+ */

+ NaClDefine(" f30fbd: Lzcnt $Gv, $Ev", NACLi_386, st, Move);

NaClDefIter(" f30fbe+@i: Invalid", 0, 1, NACLi_INVALID, st, Other);

NaClDefine(" 0fc2: Cmpps $Vps, $Wps, $Ib",

NACLi_SSE, st, Nary);