Issue 10785024: Revert 146792 - Lock-free GamepadSeqLock (try 2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 10785024: Revert 146792 - Lock-free GamepadSeqLock (try 2) (Closed)

Created:
8 years, 5 months ago by Elliot Glaysher

Modified:
8 years, 5 months ago

Reviewers:
dvyukov

CC:
chromium-reviews, jam, joi+watch-content_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, darin-cc_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

More Reviews

Description

Revert 146792 - Lock-free GamepadSeqLock (try 2) [Reverted due to crashing in ChromeBot with following stack: content::internal::GamepadSeqLockBase::ReadTo+0x1a content::GamepadSharedMemoryReader::SampleGamepads+0xaa RendererWebKitPlatformSupportImpl::sampleGamepads+0x57 WebCore::sampleGamepads+0x3f WebCore::NavigatorGamepad::gamepads+0x71 WebCore::NavigatorV8Internal::webkitGamepadsAttrGetter+0x45 v8::internal::JSObject::GetPropertyWithCallback+0x252] The change - provides an improved lock-free SeqLock implementation which eliminates any potential blocking of readers. - provides a higher-level and simpler API as was suggested by Darin. - ThreadSanitizer report suppressions are replaced with correct synchronization. - eliminates nasty kMaximumContentionCount and associated histogram. Oritignal review URL: http://codereview.chromium.org/8772004 TBR=darin@chromium.org Review URL: https://chromiumcodereview.appspot.com/10704041 TBR=dvyukov@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146896

Patch Set 1 #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+130 lines, -164 lines)			Patch
M	content/browser/gamepad/gamepad_provider.cc	View	2 chunks	+8 lines, -3 lines	0 comments	Download
M	content/browser/gamepad/gamepad_provider_unittest.cc	View	4 chunks	+16 lines, -9 lines	0 comments	Download
M	content/common/gamepad_hardware_buffer.h	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	content/common/gamepad_seqlock.h	View	2 chunks	+25 lines, -63 lines	0 comments	Download
M	content/common/gamepad_seqlock.cc	View	1 chunk	+34 lines, -72 lines	0 comments	Download
M	content/common/gamepad_seqlock_unittest.cc	View	5 chunks	+19 lines, -7 lines	0 comments	Download
M	content/content_tests.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/renderer/gamepad_shared_memory_reader.cc	View	1 chunk	+25 lines, -1 line	0 comments	Download
M	tools/valgrind/tsan/ignores.txt	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM

Expand Messages | Collapse Messages