Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 10704041: Lock-free GamepadSeqLock (try 2) (Closed)

Created:
8 years, 5 months ago by dvyukov
Modified:
6 years ago
CC:
chromium-reviews, jam, joi+watch-content_chromium.org, pam+watch_chromium.org, timurrrr+watch_chromium.org, darin-cc_chromium.org, glider+watch_chromium.org, bruening+watch_chromium.org, brettw
Visibility:
Public.

Description

Lock-free GamepadSeqLock (try 2) The change - provides an improved lock-free SeqLock implementation which eliminates any potential blocking of readers. - provides a higher-level and simpler API as was suggested by Darin. - ThreadSanitizer report suppressions are replaced with correct synchronization. - eliminates nasty kMaximumContentionCount and associated histogram. Oritignal review URL: http://codereview.chromium.org/8772004 TBR=darin@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146792

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+164 lines, -130 lines) Patch
M content/browser/gamepad/gamepad_provider.cc View 1 2 chunks +3 lines, -8 lines 0 comments Download
M content/browser/gamepad/gamepad_provider_unittest.cc View 1 4 chunks +9 lines, -16 lines 0 comments Download
M content/common/gamepad_hardware_buffer.h View 1 2 2 chunks +6 lines, -3 lines 0 comments Download
M content/common/gamepad_seqlock.h View 1 2 2 chunks +63 lines, -25 lines 0 comments Download
M content/common/gamepad_seqlock.cc View 1 2 1 chunk +72 lines, -34 lines 0 comments Download
M content/common/gamepad_seqlock_unittest.cc View 1 2 5 chunks +7 lines, -19 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/gamepad_shared_memory_reader.cc View 1 1 chunk +1 line, -25 lines 0 comments Download
M tools/valgrind/tsan/ignores.txt View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
dvyukov
Thi is essentially: http://codereview.chromium.org/8772004 which was committed and then reverted. The only change is: GamepadSeqLockBase::GamepadSeqLockBase(BaseEntry* ...
8 years, 5 months ago (2012-07-04 12:56:40 UTC) #1
dvyukov
mac_valgrind, linux_tsan, linux_rel failures seem to be unrelated. linux_asan is now green (it pointed to ...
8 years, 5 months ago (2012-07-04 13:02:30 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
8 years, 5 months ago (2012-07-04 13:08:17 UTC) #3
dvyukov
On 2012/07/04 13:08:17, I haz the power (commit-bot) wrote: > No LGTM from a valid ...
8 years, 5 months ago (2012-07-13 11:05:35 UTC) #4
darin (slow to review)
OK, LGTM
8 years, 5 months ago (2012-07-13 16:35:28 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dvyukov@chromium.org/10704041/2003
8 years, 5 months ago (2012-07-16 11:56:43 UTC) #6
commit-bot: I haz the power
Change committed as 146792
8 years, 5 months ago (2012-07-16 12:55:45 UTC) #7
Alexander Potapenko
6 years ago (2014-11-24 15:22:48 UTC) #8
Message was sent while issue was closed.
On 2012/07/16 12:55:45, I haz the power (commit-bot) wrote:
> Change committed as 146792

This CL has been reverted soon after that
(https://chromiumcodereview.appspot.com/10785024) and has never been revisited
since then.
Today the original seqlock code has been moved to
content/common/one_writer_seqlock.cc, parts of it are also used in
ppapi/proxy/gamepad_resource.cc (where they do not make much sense, IIUC).
I can try applying this CL to one_writer_seqlock.cc, not sure what to do with
gamepad_resource.cc.

Powered by Google App Engine
This is Rietveld 408576698