Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10693134: Revert 146000 - Split out ContentViewCore from ContentView for embedders. (Closed)

Created:
8 years, 5 months ago by ericu
Modified:
8 years, 5 months ago
Reviewers:
Ted C
CC:
chromium-reviews, yusukes+watch_chromium.org, erikwright (departed), jam, penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, James Su
Visibility:
Public.

Description

Revert 146000 - Split out ContentViewCore from ContentView for embedders. Some embedders do not want the additional view added by using ContentView, so we are splitting out ContentViewCore so the functionality can be used without forcing an additional FrameLayout. BUG= TEST= Review URL: https://chromiumcodereview.appspot.com/10704049 TBR=tedchoc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=146005

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+362 lines, -1468 lines) Patch
M base/android/jni_generator/jni_generator.py View 1 chunk +4 lines, -3 lines 0 comments Download
M base/android/jni_generator/jni_generator_tests.py View 7 chunks +6 lines, -7 lines 0 comments Download
M content/browser/android/browser_jni_registrar.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/android/content_settings.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/android/content_view_client.cc View 1 chunk +1 line, -1 line 0 comments Download
D content/browser/android/content_view_core_impl.h View 1 chunk +0 lines, -130 lines 0 comments Download
D content/browser/android/content_view_core_impl.cc View 1 chunk +0 lines, -276 lines 0 comments Download
A + content/browser/android/content_view_impl.h View 0 chunks +-1 lines, --1 lines 0 comments Download
A + content/browser/android/content_view_impl.cc View 0 chunks +-1 lines, --1 lines 0 comments Download
M content/browser/android/download_controller.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/android/download_controller.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.h View 4 chunks +5 lines, -5 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_android.cc View 10 chunks +23 lines, -24 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.h View 3 chunks +6 lines, -6 lines 0 comments Download
M content/browser/web_contents/web_contents_view_android.cc View 4 chunks +15 lines, -15 lines 0 comments Download
M content/content_browser.gypi View 3 chunks +3 lines, -3 lines 0 comments Download
M content/content_jni.gypi View 2 chunks +2 lines, -2 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentSettings.java View 4 chunks +9 lines, -9 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentView.java View 19 chunks +250 lines, -160 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java View 3 chunks +5 lines, -5 lines 0 comments Download
D content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java View 1 chunk +0 lines, -744 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/DownloadController.java View 4 chunks +5 lines, -5 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/ZoomManager.java View 7 chunks +16 lines, -17 lines 0 comments Download
A + content/public/browser/android/content_view.h View 0 chunks +-1 lines, --1 lines 0 comments Download
D content/public/browser/android/content_view_core.h View 1 chunk +0 lines, -43 lines 0 comments Download
M ui/gfx/native_widget_types.h View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
ericu
8 years, 5 months ago (2012-07-11 00:25:23 UTC) #1
Ted C
8 years, 5 months ago (2012-07-11 00:25:39 UTC) #2 
lgtm

Powered by Google App Engine
This is Rietveld 408576698