Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(458)

Side by Side Diff: content/public/browser/android/content_view_core.h

Issue 10693134: Revert 146000 - Split out ContentViewCore from ContentView for embedders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « content/public/browser/android/content_view.h ('k') | ui/gfx/native_widget_types.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #ifndef CONTENT_PUBLIC_BROWSER_ANDROID_CONTENT_VIEW_CORE_H_
6 #define CONTENT_PUBLIC_BROWSER_ANDROID_CONTENT_VIEW_CORE_H_
7 #pragma once
8
9 #include <jni.h>
10
11 namespace content {
12
13 class WebContents;
14
15 // Native side of the ContentViewCore.java, which is the primary way of
16 // communicating with the native Chromium code on Android. This is a
17 // public interface used by native code outside of the content module.
18 //
19 // TODO(jrg): this is a shell. Upstream the rest.
20 //
21 // TODO(jrg): downstream, this class derives from
22 // base::SupportsWeakPtr<ContentViewCore>. Issues raised in
23 // http://codereview.chromium.org/10536066/ make us want to rethink
24 // ownership issues.
25 // FOR THE MERGE (downstream), re-add derivation from
26 // base::SupportsWeakPtr<ContentViewCore> to keep everything else working
27 // until this issue is resolved.
28 // http://b/6666045
29 class ContentViewCore {
30 public:
31 virtual void Destroy(JNIEnv* env, jobject obj) = 0;
32
33 static ContentViewCore* Create(JNIEnv* env, jobject obj,
34 WebContents* web_contents);
35 static ContentViewCore* GetNativeContentViewCore(JNIEnv* env, jobject obj);
36
37 protected:
38 virtual ~ContentViewCore() {};
39 };
40
41 }; // namespace content
42
43 #endif // CONTENT_PUBLIC_BROWSER_CONTENT_VIEW_CORE_H_
OLDNEW
« no previous file with comments | « content/public/browser/android/content_view.h ('k') | ui/gfx/native_widget_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698