Issue 10704049: Split out ContentViewCore from ContentView for embedders.

Issue 10704049: Split out ContentViewCore from ContentView for embedders. (Closed)

Created:
8 years, 5 months ago by Ted C

Modified:
8 years, 5 months ago

Reviewers:
sky, John Grabowski, joth, jam, Yaron, Ben Goodger (Google)

CC:
chromium-reviews, yusukes+watch_chromium.org, erikwright (departed), penghuang+watch_chromium.org, joi+watch-content_chromium.org, darin-cc_chromium.org, brettw-cc_chromium.org, James Su, Yusuf

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Split out ContentViewCore from ContentView for embedders. Some embedders do not want the additional view added by using ContentView, so we are splitting out ContentViewCore so the functionality can be used without forcing an additional FrameLayout. BUG= TEST= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=146000

Patch Set 1 #

Patch Set 2 : Rebase #

Created: 8 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+616 lines, -964 lines)			Patch
M	base/android/jni_generator/jni_generator.py	View	1	1 chunk	+3 lines, -4 lines	0 comments	Download
M	base/android/jni_generator/jni_generator_tests.py	View	1	7 chunks	+7 lines, -6 lines	0 comments	Download
M	content/browser/android/browser_jni_registrar.cc	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/browser/android/content_settings.cc	View		2 chunks	+3 lines, -3 lines	0 comments	Download
M	content/browser/android/content_view_client.cc	View	1	1 chunk	+1 line, -1 line	0 comments	Download
A +	content/browser/android/content_view_core_impl.h	View	1	5 chunks	+14 lines, -14 lines	0 comments	Download
A +	content/browser/android/content_view_core_impl.cc	View	1	13 chunks	+58 lines, -57 lines	0 comments	Download
D	content/browser/android/content_view_impl.h	View	1	1 chunk	+0 lines, -130 lines	0 comments	Download
D	content/browser/android/content_view_impl.cc	View	1	1 chunk	+0 lines, -275 lines	0 comments	Download
M	content/browser/android/download_controller.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	content/browser/android/download_controller.cc	View		4 chunks	+7 lines, -6 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_android.h	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	content/browser/renderer_host/render_widget_host_view_android.cc	View	1	10 chunks	+24 lines, -23 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_android.h	View	1	3 chunks	+6 lines, -6 lines	0 comments	Download
M	content/browser/web_contents/web_contents_view_android.cc	View	1	4 chunks	+15 lines, -15 lines	0 comments	Download
M	content/content_browser.gypi	View	1	3 chunks	+3 lines, -3 lines	0 comments	Download
M	content/content_jni.gypi	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentSettings.java	View		4 chunks	+9 lines, -9 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentView.java	View	1	19 chunks	+160 lines, -250 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ContentViewClient.java	View		3 chunks	+5 lines, -5 lines	0 comments	Download
A +	content/public/android/java/src/org/chromium/content/browser/ContentViewCore.java	View	1	24 chunks	+223 lines, -80 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/DownloadController.java	View		4 chunks	+5 lines, -5 lines	0 comments	Download
M	content/public/android/java/src/org/chromium/content/browser/ZoomManager.java	View		7 chunks	+17 lines, -16 lines	0 comments	Download
D	content/public/browser/android/content_view.h	View		1 chunk	+0 lines, -43 lines	0 comments	Download
A	content/public/browser/android/content_view_core.h	View		1 chunk	+43 lines, -0 lines	0 comments	Download
M	ui/gfx/native_widget_types.h	View		2 chunks	+3 lines, -3 lines	0 comments	Download

Messages

Total messages: 10 (0 generated)

Expand Messages | Collapse Messages

Ted C

This is a "relatively" straight forward split and I tried to keep changes to a ...

8 years, 5 months ago (2012-06-29 21:08:30 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/10704049/7001

8 years, 5 months ago (2012-07-10 20:39:47 UTC) #7

commit-bot: I haz the power

Try job failure for 10704049-7001 (retry) on win for step "compile" (clobber build). It's a ...

8 years, 5 months ago (2012-07-10 22:23:24 UTC) #8

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tedchoc@chromium.org/10704049/7001

8 years, 5 months ago (2012-07-10 22:27:23 UTC) #9

Change committed as 146000

Expand Messages | Collapse Messages