Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1459)

Unified Diff: content/public/browser/android/content_view_core.h

Issue 10693134: Revert 146000 - Split out ContentViewCore from ContentView for embedders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/browser/android/content_view.h ('k') | ui/gfx/native_widget_types.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/browser/android/content_view_core.h
===================================================================
--- content/public/browser/android/content_view_core.h (revision 146004)
+++ content/public/browser/android/content_view_core.h (working copy)
@@ -1,43 +0,0 @@
-// Copyright (c) 2012 The Chromium Authors. All rights reserved.
-// Use of this source code is governed by a BSD-style license that can be
-// found in the LICENSE file.
-
-#ifndef CONTENT_PUBLIC_BROWSER_ANDROID_CONTENT_VIEW_CORE_H_
-#define CONTENT_PUBLIC_BROWSER_ANDROID_CONTENT_VIEW_CORE_H_
-#pragma once
-
-#include <jni.h>
-
-namespace content {
-
-class WebContents;
-
-// Native side of the ContentViewCore.java, which is the primary way of
-// communicating with the native Chromium code on Android. This is a
-// public interface used by native code outside of the content module.
-//
-// TODO(jrg): this is a shell. Upstream the rest.
-//
-// TODO(jrg): downstream, this class derives from
-// base::SupportsWeakPtr<ContentViewCore>. Issues raised in
-// http://codereview.chromium.org/10536066/ make us want to rethink
-// ownership issues.
-// FOR THE MERGE (downstream), re-add derivation from
-// base::SupportsWeakPtr<ContentViewCore> to keep everything else working
-// until this issue is resolved.
-// http://b/6666045
-class ContentViewCore {
- public:
- virtual void Destroy(JNIEnv* env, jobject obj) = 0;
-
- static ContentViewCore* Create(JNIEnv* env, jobject obj,
- WebContents* web_contents);
- static ContentViewCore* GetNativeContentViewCore(JNIEnv* env, jobject obj);
-
- protected:
- virtual ~ContentViewCore() {};
-};
-
-}; // namespace content
-
-#endif // CONTENT_PUBLIC_BROWSER_CONTENT_VIEW_CORE_H_
« no previous file with comments | « content/public/browser/android/content_view.h ('k') | ui/gfx/native_widget_types.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698