Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1820)

Unified Diff: base/android/jni_generator/jni_generator_tests.py

Issue 10693134: Revert 146000 - Split out ContentViewCore from ContentView for embedders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Created 8 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/android/jni_generator/jni_generator.py ('k') | content/browser/android/browser_jni_registrar.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/android/jni_generator/jni_generator_tests.py
===================================================================
--- base/android/jni_generator/jni_generator_tests.py (revision 146004)
+++ base/android/jni_generator/jni_generator_tests.py (working copy)
@@ -54,7 +54,6 @@
print '=' * 80
self.fail('Golden text mismatch')
- # TODO(bulach): Detangle these tests from knowing about classes from Content.
def testNatives(self):
test_data = """"
private native int nativeInit();
@@ -65,7 +64,7 @@
private static native String nativeGetDomainAndRegistry(String url);
private static native void nativeCreateHistoricalTabFromState(
byte[] state, int tab_index);
- private native byte[] nativeGetStateAsByteArray(ContentViewCore view);
+ private native byte[] nativeGetStateAsByteArray(ContentView view);
private static native String[] nativeGetAutofillProfileGUIDs();
private native void nativeSetRecognitionResults(
int sessionId, String[] results);
@@ -126,7 +125,7 @@
type='function'),
NativeMethod(return_type='byte[]', static=False,
name='GetStateAsByteArray',
- params=[Param(datatype='ContentViewCore', name='view')],
+ params=[Param(datatype='ContentView', name='view')],
java_class_name=None,
type='function'),
NativeMethod(return_type='String[]', static=True,
@@ -360,7 +359,7 @@
"V", reinterpret_cast<void*>(CreateHistoricalTabFromState) },
{ "nativeGetStateAsByteArray",
"("
-"Lorg/chromium/content/browser/ContentViewCore;"
+"Lorg/chromium/content/browser/ContentView;"
")"
"[B", reinterpret_cast<void*>(GetStateAsByteArray) },
{ "nativeGetAutofillProfileGUIDs",
@@ -755,7 +754,7 @@
void dismiss();
@SuppressWarnings("unused")
@CalledByNative
- private static boolean shouldShowAutoLogin(ContentViewCore contentView,
+ private static boolean shouldShowAutoLogin(ContentView contentView,
String realm, String account, String args) {
AccountManagerContainer accountManagerContainer =
new AccountManagerContainer((Activity)contentView.getContext(),
@@ -827,7 +826,7 @@
name='shouldShowAutoLogin',
method_id_var_name='shouldShowAutoLogin',
java_class_name='',
- params=[Param(datatype='ContentViewCore', name='contentView'),
+ params=[Param(datatype='ContentView', name='contentView'),
Param(datatype='String', name='realm'),
Param(datatype='String', name='account'),
Param(datatype='String', name='args')],
@@ -1062,7 +1061,7 @@
"shouldShowAutoLogin",
"("
-"Lorg/chromium/content/browser/ContentViewCore;"
+"Lorg/chromium/content/browser/ContentView;"
"Ljava/lang/String;"
"Ljava/lang/String;"
"Ljava/lang/String;"
« no previous file with comments | « base/android/jni_generator/jni_generator.py ('k') | content/browser/android/browser_jni_registrar.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698