Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(444)

Issue 10540047: Add support to be able to asynchronously read from a CancelableSyncSocket (Closed)

Created:
8 years, 6 months ago by tommi (sloooow) - chröme
Modified:
8 years, 6 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Visibility:
Public.

Description

Add support to be able to asynchronously read from a CancelableSyncSocket on a TYPE_IO message loop thread. This makes it easy to share a thread that uses a message loop (e.g. for IPC and other things) and not require a separate thread to read from the socket. TEST=Run media_unittests. (--gtest_filter=AsyncSocketIoHandlerTest.*) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=140994

Patch Set 1 #

Total comments: 12

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+363 lines, -8 lines) Patch
A media/audio/async_socket_io_handler.h View 1 1 chunk +108 lines, -0 lines 0 comments Download
A media/audio/async_socket_io_handler_posix.cc View 1 1 chunk +89 lines, -0 lines 0 comments Download
A media/audio/async_socket_io_handler_unittest.cc View 1 chunk +80 lines, -0 lines 0 comments Download
A media/audio/async_socket_io_handler_win.cc View 1 1 chunk +74 lines, -0 lines 0 comments Download
M media/media.gyp View 3 chunks +12 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tommi (sloooow) - chröme
8 years, 6 months ago (2012-06-07 12:10:58 UTC) #1
henrika (OOO until Aug 14)
Amazing stuff. Did not dig into the details at this stage. Mainly nits. LGTM.
8 years, 6 months ago (2012-06-07 12:25:48 UTC) #2
henrika (OOO until Aug 14)
https://chromiumcodereview.appspot.com/10540047/diff/1/media/audio/async_socket_io_handler.h File media/audio/async_socket_io_handler.h (right): https://chromiumcodereview.appspot.com/10540047/diff/1/media/audio/async_socket_io_handler.h#newcode76 media/audio/async_socket_io_handler.h:76: // Private implementation. Remove comment? https://chromiumcodereview.appspot.com/10540047/diff/1/media/audio/async_socket_io_handler.h#newcode91 media/audio/async_socket_io_handler.h:91: // Member ...
8 years, 6 months ago (2012-06-07 12:25:59 UTC) #3
tommi (sloooow) - chröme
8 years, 6 months ago (2012-06-07 12:34:33 UTC) #4
https://chromiumcodereview.appspot.com/10540047/diff/1/media/audio/async_sock...
File media/audio/async_socket_io_handler.h (right):

https://chromiumcodereview.appspot.com/10540047/diff/1/media/audio/async_sock...
media/audio/async_socket_io_handler.h:76: // Private implementation.
On 2012/06/07 12:25:59, henrika wrote:
> Remove comment?

Done.

https://chromiumcodereview.appspot.com/10540047/diff/1/media/audio/async_sock...
media/audio/async_socket_io_handler.h:91: // Member variables.
On 2012/06/07 12:25:59, henrika wrote:
> Needed?

Done.

https://chromiumcodereview.appspot.com/10540047/diff/1/media/audio/async_sock...
File media/audio/async_socket_io_handler_posix.cc (right):

https://chromiumcodereview.appspot.com/10540047/diff/1/media/audio/async_sock...
media/audio/async_socket_io_handler_posix.cc:25: pending_buffer_len_));
On 2012/06/07 12:25:59, henrika wrote:
> nit, fix indentation

Done.

https://chromiumcodereview.appspot.com/10540047/diff/1/media/audio/async_sock...
media/audio/async_socket_io_handler_posix.cc:39: const ReadCompleteCallback&
callback) {
On 2012/06/07 12:25:59, henrika wrote:
> odd indentation

Done.

https://chromiumcodereview.appspot.com/10540047/diff/1/media/audio/async_sock...
File media/audio/async_socket_io_handler_win.cc (right):

https://chromiumcodereview.appspot.com/10540047/diff/1/media/audio/async_sock...
media/audio/async_socket_io_handler_win.cc:50: &context_->overlapped);
On 2012/06/07 12:25:59, henrika wrote:
> fix indentation

Done.

https://chromiumcodereview.appspot.com/10540047/diff/1/media/audio/async_sock...
media/audio/async_socket_io_handler_win.cc:54: // The completion port will be
signaled regardless of completing the read
On 2012/06/07 12:25:59, henrika wrote:
> Odd place to place a comment.

Done. Also improved the comment.

Powered by Google App Engine
This is Rietveld 408576698