Made ownership of DownloadRequestHandles clear through scoped_ptr<>

Made ownership of DownloadRequestHandles clear through scoped_ptr<>

BUG=None
TEST=Memory bots pass.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141735

[Randy Smith (Not in Mondays), 2012-06-12 19:22:58]

Asanka: Could you take a quick look at this?  I'm breaking the memory bots, so
I'm wanting to get it in ASAP.

[Randy Smith (Not in Mondays), 2012-06-12 19:25:04]

Whoops, Asanka doesn't seem to be online.  Ben, could you take a look?

For context, my recent commit broke the following builds:

  
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20OS%20%28v....

  
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Heapcheck/bu...
  
  
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%20Mac%20%28...
  

and this fixes it by making sure that, when the DownloadRequestHandle is dropped
on the floor, it makes it to the drain :-}.  (And makes ownership explicit along
the DRH allocation and passing path.)

[Randy Smith (Not in Mondays), 2012-06-12 19:27:55]

Flop; I have an ack from Asanka, and he reviewed the original CL and so knows
the code.  Ben, you're off the hook.

On 2012/06/12 19:25:04, rdsmith wrote:
> Whoops, Asanka doesn't seem to be online.  Ben, could you take a look?
> 
> For context, my recent commit broke the following builds:
> 
>   
>
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%2520OS%2520....
> 
>   
>
http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%2520Heapcheck/...
>   
>   
>
http://build.chromium.org/p/chromium.memory.fyi/builders/Chromium%2520Mac%252...
>   
> 
> and this fixes it by making sure that, when the DownloadRequestHandle is
dropped
> on the floor, it makes it to the drain :-}.  (And makes ownership explicit
along
> the DRH allocation and passing path.)

[Alexander Potapenko, 2012-06-12 19:30:06]

http://codereview.chromium.org/10535135/diff/1/content/browser/download/downl...
File content/browser/download/download_item_factory.h (right):

http://codereview.chromium.org/10535135/diff/1/content/browser/download/downl...
content/browser/download/download_item_factory.h:13: #include
"content/browser/download/download_item_impl.h"
I'm no good at Chromium style, but shouldn't this #include directive go together
with the one you've just added?

[asanka, 2012-06-12 19:33:20]

LGTM

[Randy Smith (Not in Mondays), 2012-06-12 19:37:30]

http://codereview.chromium.org/10535135/diff/1/content/browser/download/downl...
File content/browser/download/download_item_factory.h (right):

http://codereview.chromium.org/10535135/diff/1/content/browser/download/downl...
content/browser/download/download_item_factory.h:13: #include
"content/browser/download/download_item_impl.h"
On 2012/06/12 19:30:06, Alexander Potapenko wrote:
> I'm no good at Chromium style, but shouldn't this #include directive go
together
> with the one you've just added?

Whoops--that was a copy and paste error + confusion about being in a .h file
rather than a .cc file (I had in my mind that the first include was the
"corresponding .h to a .cc file").  Will fix; thanks for pointing it out.

[commit-bot: I haz the power, 2012-06-12 19:46:18]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rdsmith@chromium.org/10535135/10001

[commit-bot: I haz the power, 2012-06-12 20:58:21]

Change committed as 141735