content/browser/download/download_item_impl.h - Issue 10535135: Made ownership of DownloadRequestHandles clear through scoped_ptr<>

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/download/download_item_impl.h

Issue 10535135: Made ownership of DownloadRequestHandles clear through scoped_ptr<> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Incorporated comments. Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/download/download_item_impl.h

diff --git a/content/browser/download/download_item_impl.h b/content/browser/download/download_item_impl.h

index 2b1d7c88e4afd99189b4707a419f5d8950fbe7ae..b3c5dd39edccf2260180d382828350e43b28aa19 100644

--- a/content/browser/download/download_item_impl.h

+++ b/content/browser/download/download_item_impl.h

@@ -93,11 +93,10 @@ class CONTENT_EXPORT DownloadItemImpl : public content::DownloadItem {

const net::BoundNetLog& bound_net_log);

// Constructing for a regular download.

- // Takes ownership of the object pointed to by |request_handle|.

// |bound_net_log| is constructed externally for our use.

DownloadItemImpl(Delegate* delegate,

const DownloadCreateInfo& info,

- DownloadRequestHandleInterface* request_handle,

+ scoped_ptr<DownloadRequestHandleInterface> request_handle,

bool is_otr,

const net::BoundNetLog& bound_net_log);