Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(499)

Side by Side Diff: content/browser/download/download_item_impl.h

Issue 10535135: Made ownership of DownloadRequestHandles clear through scoped_ptr<> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_ 5 #ifndef CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_
6 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_ 6 #define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_
7 #pragma once 7 #pragma once
8 8
9 #include <string> 9 #include <string>
10 10
(...skipping 75 matching lines...) Expand 10 before | Expand all | Expand 10 after
86 // outlives the DownloadItemImpl. 86 // outlives the DownloadItemImpl.
87 87
88 // Constructing from persistent store: 88 // Constructing from persistent store:
89 // |bound_net_log| is constructed externally for our use. 89 // |bound_net_log| is constructed externally for our use.
90 DownloadItemImpl(Delegate* delegate, 90 DownloadItemImpl(Delegate* delegate,
91 content::DownloadId download_id, 91 content::DownloadId download_id,
92 const content::DownloadPersistentStoreInfo& info, 92 const content::DownloadPersistentStoreInfo& info,
93 const net::BoundNetLog& bound_net_log); 93 const net::BoundNetLog& bound_net_log);
94 94
95 // Constructing for a regular download. 95 // Constructing for a regular download.
96 // Takes ownership of the object pointed to by |request_handle|.
97 // |bound_net_log| is constructed externally for our use. 96 // |bound_net_log| is constructed externally for our use.
98 DownloadItemImpl(Delegate* delegate, 97 DownloadItemImpl(Delegate* delegate,
99 const DownloadCreateInfo& info, 98 const DownloadCreateInfo& info,
100 DownloadRequestHandleInterface* request_handle, 99 scoped_ptr<DownloadRequestHandleInterface> request_handle,
101 bool is_otr, 100 bool is_otr,
102 const net::BoundNetLog& bound_net_log); 101 const net::BoundNetLog& bound_net_log);
103 102
104 // Constructing for the "Save Page As..." feature: 103 // Constructing for the "Save Page As..." feature:
105 // |bound_net_log| is constructed externally for our use. 104 // |bound_net_log| is constructed externally for our use.
106 DownloadItemImpl(Delegate* delegate, 105 DownloadItemImpl(Delegate* delegate,
107 const FilePath& path, 106 const FilePath& path,
108 const GURL& url, 107 const GURL& url,
109 bool is_otr, 108 bool is_otr,
110 content::DownloadId download_id, 109 content::DownloadId download_id,
(...skipping 320 matching lines...) Expand 10 before | Expand all | Expand 10 after
431 430
432 // Net log to use for this download. 431 // Net log to use for this download.
433 const net::BoundNetLog bound_net_log_; 432 const net::BoundNetLog bound_net_log_;
434 433
435 base::WeakPtrFactory<DownloadItemImpl> weak_ptr_factory_; 434 base::WeakPtrFactory<DownloadItemImpl> weak_ptr_factory_;
436 435
437 DISALLOW_COPY_AND_ASSIGN(DownloadItemImpl); 436 DISALLOW_COPY_AND_ASSIGN(DownloadItemImpl);
438 }; 437 };
439 438
440 #endif // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_ 439 #endif // CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_IMPL_H_
OLDNEW
« no previous file with comments | « content/browser/download/download_item_factory.h ('k') | content/browser/download/download_item_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698