Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4544)

Unified Diff: content/browser/download/download_item_factory.h

Issue 10535135: Made ownership of DownloadRequestHandles clear through scoped_ptr<> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/browser/download/download_item_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_item_factory.h
diff --git a/content/browser/download/download_item_factory.h b/content/browser/download/download_item_factory.h
index 84110d9f31d6a22f5d2fa54c56b39e86fdcb93bf..7f4e472c5ab979f1bf9d388823fa936fb539a8cc 100644
--- a/content/browser/download/download_item_factory.h
+++ b/content/browser/download/download_item_factory.h
@@ -10,10 +10,11 @@
#define CONTENT_BROWSER_DOWNLOAD_DOWNLOAD_ITEM_FACTORY_H_
#pragma once
-#include "content/browser/download/download_item_impl.h"
-
#include <string>
+#include "base/memory/scoped_ptr.h"
+#include "content/browser/download/download_item_impl.h"
+
struct DownloadCreateInfo;
class DownloadRequestHandleInterface;
class FilePath;
@@ -44,7 +45,7 @@ public:
virtual content::DownloadItem* CreateActiveItem(
DownloadItemImpl::Delegate* delegate,
const DownloadCreateInfo& info,
- DownloadRequestHandleInterface* request_handle,
+ scoped_ptr<DownloadRequestHandleInterface> request_handle,
bool is_otr,
const net::BoundNetLog& bound_net_log) = 0;
« no previous file with comments | « no previous file | content/browser/download/download_item_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698