Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(956)

Unified Diff: content/browser/download/download_item_impl_unittest.cc

Issue 10535135: Made ownership of DownloadRequestHandles clear through scoped_ptr<> (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Incorporated comments. Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/download/download_item_impl.cc ('k') | content/browser/download/download_manager_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/download/download_item_impl_unittest.cc
diff --git a/content/browser/download/download_item_impl_unittest.cc b/content/browser/download/download_item_impl_unittest.cc
index d81d3d1a1e745d732a6ceca9607a1d4df4f6f8ba..5c52f4c91c2d83de8d2f4da8a3ccad5334f01d86 100644
--- a/content/browser/download/download_item_impl_unittest.cc
+++ b/content/browser/download/download_item_impl_unittest.cc
@@ -185,11 +185,11 @@ class DownloadItemTest : public testing::Test {
info_->url_chain.push_back(GURL());
info_->state = state;
- MockRequestHandle* request_handle =
- new testing::NiceMock<MockRequestHandle>;
+ scoped_ptr<DownloadRequestHandleInterface> request_handle(
+ new testing::NiceMock<MockRequestHandle>);
DownloadItem* download =
new DownloadItemImpl(&delegate_, *(info_.get()),
- request_handle, false, net::BoundNetLog());
+ request_handle.Pass(), false, net::BoundNetLog());
allocated_downloads_.insert(download);
return download;
}
« no previous file with comments | « content/browser/download/download_item_impl.cc ('k') | content/browser/download/download_manager_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698