Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(250)

Issue 10443075: Coverity PASS_BY_VALUE fix. (Closed)

Created:
8 years, 6 months ago by Sheridan Rawlins
Modified:
8 years, 6 months ago
CC:
chromium-reviews, Aaron Boodman, jeremya+watch_chromium.org, mihaip-chromium-reviews_chromium.org, Evan Stade
Visibility:
Public.

Description

Coverity PASS_BY_VALUE fix. CID=104112, 104110, 104109 BUG=None TEST= R=jeremya@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=141785

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -10 lines) Patch
M chrome/browser/ui/cocoa/extensions/shell_window_cocoa.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.h View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/extensions/shell_window.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/shell_window_gtk.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/extensions/shell_window_gtk.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/extensions/shell_window_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
Sheridan Rawlins
8 years, 6 months ago (2012-06-01 06:00:40 UTC) #1
jeremya
lgtm
8 years, 6 months ago (2012-06-01 06:05:01 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scr@chromium.org/10443075/1
8 years, 6 months ago (2012-06-01 06:06:05 UTC) #3
commit-bot: I haz the power
Presubmit check for 10443075-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-01 06:06:17 UTC) #4
Mihai Parparita -not on Chrome
LGTM for chrome/browser/ui/extensions
8 years, 6 months ago (2012-06-01 06:31:05 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scr@chromium.org/10443075/1
8 years, 6 months ago (2012-06-01 06:43:42 UTC) #6
commit-bot: I haz the power
Presubmit check for 10443075-1 failed and returned exit status 1. Running presubmit commit checks ...
8 years, 6 months ago (2012-06-01 06:43:49 UTC) #7
Sheridan Rawlins
Scott, does your OWNER @ chrome/browser/ui count for the three missing OWNER LG's? Let me ...
8 years, 6 months ago (2012-06-01 18:53:18 UTC) #8
sky
LGTM
8 years, 6 months ago (2012-06-12 20:59:04 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scr@chromium.org/10443075/1
8 years, 6 months ago (2012-06-12 21:11:43 UTC) #10
commit-bot: I haz the power
Failed to apply patch for chrome/browser/ui/views/extensions/shell_window_views.cc: While running patch -p1 --forward --force; patching file chrome/browser/ui/views/extensions/shell_window_views.cc ...
8 years, 6 months ago (2012-06-12 21:11:58 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/scr@chromium.org/10443075/9001
8 years, 6 months ago (2012-06-12 21:52:45 UTC) #12
commit-bot: I haz the power
8 years, 6 months ago (2012-06-12 23:33:45 UTC) #13
Change committed as 141785

Powered by Google App Engine
This is Rietveld 408576698