Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Unified Diff: chrome/browser/ui/gtk/extensions/shell_window_gtk.cc

Issue 10443075: Coverity PASS_BY_VALUE fix. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/gtk/extensions/shell_window_gtk.cc
diff --git a/chrome/browser/ui/gtk/extensions/shell_window_gtk.cc b/chrome/browser/ui/gtk/extensions/shell_window_gtk.cc
index b2b85d4783f44e61fb2d66ba7758337ee4f0250e..19163afd32c4eed28d98658973d221ce25e92433 100644
--- a/chrome/browser/ui/gtk/extensions/shell_window_gtk.cc
+++ b/chrome/browser/ui/gtk/extensions/shell_window_gtk.cc
@@ -15,7 +15,7 @@
ShellWindowGtk::ShellWindowGtk(Profile* profile,
const extensions::Extension* extension,
const GURL& url,
- const ShellWindow::CreateParams params)
+ const ShellWindow::CreateParams& params)
: ShellWindow(profile, extension, url),
state_(GDK_WINDOW_STATE_WITHDRAWN),
is_active_(!ui::ActiveWindowWatcherX::WMSupportsActivation()) {
@@ -174,6 +174,6 @@ gboolean ShellWindowGtk::OnWindowState(GtkWidget* sender,
ShellWindow* ShellWindow::CreateImpl(Profile* profile,
const extensions::Extension* extension,
const GURL& url,
- const ShellWindow::CreateParams params) {
+ const ShellWindow::CreateParams& params) {
return new ShellWindowGtk(profile, extension, url, params);
}
« no previous file with comments | « chrome/browser/ui/gtk/extensions/shell_window_gtk.h ('k') | chrome/browser/ui/views/extensions/shell_window_views.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698