Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(321)

Side by Side Diff: chrome/browser/ui/cocoa/extensions/shell_window_cocoa.h

Issue 10443075: Coverity PASS_BY_VALUE fix. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_COCOA_EXTENSIONS_SHELL_WINDOW_COCOA_H_ 5 #ifndef CHROME_BROWSER_UI_COCOA_EXTENSIONS_SHELL_WINDOW_COCOA_H_
6 #define CHROME_BROWSER_UI_COCOA_EXTENSIONS_SHELL_WINDOW_COCOA_H_ 6 #define CHROME_BROWSER_UI_COCOA_EXTENSIONS_SHELL_WINDOW_COCOA_H_
7 #pragma once 7 #pragma once
8 8
9 #import <Cocoa/Cocoa.h> 9 #import <Cocoa/Cocoa.h>
10 10
(...skipping 15 matching lines...) Expand all
26 @property(assign, nonatomic) ShellWindowCocoa* shellWindow; 26 @property(assign, nonatomic) ShellWindowCocoa* shellWindow;
27 27
28 @end 28 @end
29 29
30 // Cocoa bridge to ShellWindow. 30 // Cocoa bridge to ShellWindow.
31 class ShellWindowCocoa : public ShellWindow { 31 class ShellWindowCocoa : public ShellWindow {
32 public: 32 public:
33 ShellWindowCocoa(Profile* profile, 33 ShellWindowCocoa(Profile* profile,
34 const extensions::Extension* extension, 34 const extensions::Extension* extension,
35 const GURL& url, 35 const GURL& url,
36 const CreateParams params); 36 const CreateParams& params);
37 37
38 // BaseWindow implementation. 38 // BaseWindow implementation.
39 virtual bool IsActive() const OVERRIDE; 39 virtual bool IsActive() const OVERRIDE;
40 virtual bool IsMaximized() const OVERRIDE; 40 virtual bool IsMaximized() const OVERRIDE;
41 virtual bool IsMinimized() const OVERRIDE; 41 virtual bool IsMinimized() const OVERRIDE;
42 virtual bool IsFullscreen() const OVERRIDE; 42 virtual bool IsFullscreen() const OVERRIDE;
43 virtual gfx::NativeWindow GetNativeWindow() OVERRIDE; 43 virtual gfx::NativeWindow GetNativeWindow() OVERRIDE;
44 virtual gfx::Rect GetRestoredBounds() const OVERRIDE; 44 virtual gfx::Rect GetRestoredBounds() const OVERRIDE;
45 virtual gfx::Rect GetBounds() const OVERRIDE; 45 virtual gfx::Rect GetBounds() const OVERRIDE;
46 virtual void Show() OVERRIDE; 46 virtual void Show() OVERRIDE;
(...skipping 17 matching lines...) Expand all
64 64
65 NSWindow* window() const; 65 NSWindow* window() const;
66 66
67 scoped_nsobject<ShellWindowController> window_controller_; 67 scoped_nsobject<ShellWindowController> window_controller_;
68 NSInteger attention_request_id_; // identifier from requestUserAttention 68 NSInteger attention_request_id_; // identifier from requestUserAttention
69 69
70 DISALLOW_COPY_AND_ASSIGN(ShellWindowCocoa); 70 DISALLOW_COPY_AND_ASSIGN(ShellWindowCocoa);
71 }; 71 };
72 72
73 #endif // CHROME_BROWSER_UI_COCOA_EXTENSIONS_SHELL_WINDOW_COCOA_H_ 73 #endif // CHROME_BROWSER_UI_COCOA_EXTENSIONS_SHELL_WINDOW_COCOA_H_
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/extensions/shell_window_cocoa.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698