Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(485)

Side by Side Diff: chrome/browser/ui/extensions/shell_window.cc

Issue 10443075: Coverity PASS_BY_VALUE fix. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase Created 8 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/extensions/shell_window.h" 5 #include "chrome/browser/ui/extensions/shell_window.h"
6 6
7 #include "base/utf_string_conversions.h" 7 #include "base/utf_string_conversions.h"
8 #include "chrome/browser/extensions/extension_process_manager.h" 8 #include "chrome/browser/extensions/extension_process_manager.h"
9 #include "chrome/browser/extensions/shell_window_registry.h" 9 #include "chrome/browser/extensions/shell_window_registry.h"
10 #include "chrome/browser/file_select_helper.h" 10 #include "chrome/browser/file_select_helper.h"
(...skipping 29 matching lines...) Expand all
40 } // namespace 40 } // namespace
41 41
42 ShellWindow::CreateParams::CreateParams() 42 ShellWindow::CreateParams::CreateParams()
43 : frame(ShellWindow::CreateParams::FRAME_CHROME), 43 : frame(ShellWindow::CreateParams::FRAME_CHROME),
44 bounds(10, 10, kDefaultWidth, kDefaultHeight) { 44 bounds(10, 10, kDefaultWidth, kDefaultHeight) {
45 } 45 }
46 46
47 ShellWindow* ShellWindow::Create(Profile* profile, 47 ShellWindow* ShellWindow::Create(Profile* profile,
48 const extensions::Extension* extension, 48 const extensions::Extension* extension,
49 const GURL& url, 49 const GURL& url,
50 const ShellWindow::CreateParams params) { 50 const ShellWindow::CreateParams& params) {
51 // This object will delete itself when the window is closed. 51 // This object will delete itself when the window is closed.
52 ShellWindow* window = 52 ShellWindow* window =
53 ShellWindow::CreateImpl(profile, extension, url, params); 53 ShellWindow::CreateImpl(profile, extension, url, params);
54 ShellWindowRegistry::Get(profile)->AddShellWindow(window); 54 ShellWindowRegistry::Get(profile)->AddShellWindow(window);
55 return window; 55 return window;
56 } 56 }
57 57
58 ShellWindow::ShellWindow(Profile* profile, 58 ShellWindow::ShellWindow(Profile* profile,
59 const extensions::Extension* extension, 59 const extensions::Extension* extension,
60 const GURL& url) 60 const GURL& url)
(...skipping 145 matching lines...) Expand 10 before | Expand all | Expand 10 after
206 } 206 }
207 207
208 ExtensionWindowController* ShellWindow::GetExtensionWindowController() const { 208 ExtensionWindowController* ShellWindow::GetExtensionWindowController() const {
209 return NULL; 209 return NULL;
210 } 210 }
211 211
212 void ShellWindow::OnRequest(const ExtensionHostMsg_Request_Params& params) { 212 void ShellWindow::OnRequest(const ExtensionHostMsg_Request_Params& params) {
213 extension_function_dispatcher_.Dispatch(params, 213 extension_function_dispatcher_.Dispatch(params,
214 web_contents_->GetRenderViewHost()); 214 web_contents_->GetRenderViewHost());
215 } 215 }
OLDNEW
« no previous file with comments | « chrome/browser/ui/extensions/shell_window.h ('k') | chrome/browser/ui/gtk/extensions/shell_window_gtk.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698