chrome/browser/ui/extensions/shell_window.cc - Issue 10443075: Coverity PASS_BY_VALUE fix.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/extensions/shell_window.cc

Issue 10443075: Coverity PASS_BY_VALUE fix. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: rebase Created 8 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/extensions/shell_window.cc

diff --git a/chrome/browser/ui/extensions/shell_window.cc b/chrome/browser/ui/extensions/shell_window.cc

index dea51c243c9fa740301325e15f16da0112219816..ca41ef1fd9a9575d67dccb6c2a02077616043d80 100644

--- a/chrome/browser/ui/extensions/shell_window.cc

+++ b/chrome/browser/ui/extensions/shell_window.cc

@@ -47,7 +47,7 @@ ShellWindow::CreateParams::CreateParams()

ShellWindow* ShellWindow::Create(Profile* profile,

const extensions::Extension* extension,

const GURL& url,

- const ShellWindow::CreateParams params) {

+ const ShellWindow::CreateParams& params) {

// This object will delete itself when the window is closed.

ShellWindow* window =

ShellWindow::CreateImpl(profile, extension, url, params);