RefCounted types should not have public destructors, Linux fixes

RefCounted types should not have public destructors, Linux fixes

BUG=123295
TEST=none


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=137893

[Ryan Sleevi, 2012-05-18 01:21:21]

Stamp collecting time. Various fixes throughout the tree for Linux builds

jar: base/ , net/
sergeyu: remoting/
satorux: dbus/
gman: ui/gl/, gpu/
sky: chrome/* (bulk in chrome/browser/ui), content/browser
fischman: media/

[satorux1, 2012-05-18 01:24:34]

dbus/ LGTM. Thanks!

[Wez, 2012-05-18 01:28:16]

remoting/ LGTM.

[jar (doing other things), 2012-05-18 01:36:52]

LGTM for base/* and net/*

[greggman, 2012-05-18 01:44:13]

lgtm

[Ami GONE FROM CHROMIUM, 2012-05-18 01:58:50]

lgtm

http://codereview.chromium.org/10392152/diff/1/media/base/stream_parser_buffer.h
File media/base/stream_parser_buffer.h (right):

http://codereview.chromium.org/10392152/diff/1/media/base/stream_parser_buffe...
media/base/stream_parser_buffer.h:25: virtual ~StreamParserBuffer() {}
I realize that this was (implicitly) inline before as well, but any reason to
perpetuate  it?

[Ryan Sleevi, 2012-05-18 02:07:19]

http://codereview.chromium.org/10392152/diff/1/media/base/stream_parser_buffer.h
File media/base/stream_parser_buffer.h (right):

http://codereview.chromium.org/10392152/diff/1/media/base/stream_parser_buffe...
media/base/stream_parser_buffer.h:25: virtual ~StreamParserBuffer() {}
On 2012/05/18 01:58:51, Ami Fischman wrote:
> I realize that this was (implicitly) inline before as well, but any reason to
> perpetuate  it?

Mostly due to the triviality of the dtor.

[sky, 2012-05-18 15:40:47]

LGTM

[commit-bot: I haz the power, 2012-05-18 16:23:23]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/rsleevi@chromium.org/10392152/1

[commit-bot: I haz the power, 2012-05-18 18:00:31]

Change committed as 137893