Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1007)

Unified Diff: net/curvecp/server_packetizer.h

Issue 10392152: RefCounted types should not have public destructors, Linux fixes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/curvecp/server_packetizer.h
diff --git a/net/curvecp/server_packetizer.h b/net/curvecp/server_packetizer.h
index ba425863fd18152bcc51a2c632a1f25b12f6187e..8ba83c11dcd24db309f7073895d7cd5be88cd80b 100644
--- a/net/curvecp/server_packetizer.h
+++ b/net/curvecp/server_packetizer.h
@@ -25,7 +25,6 @@ class ServerPacketizer : public base::RefCounted<ServerPacketizer>,
public Packetizer {
public:
ServerPacketizer();
- virtual ~ServerPacketizer();
// Listen for new connections from the Packetizer.
int Listen(const IPEndPoint& endpoint, Packetizer::Listener* listener);
@@ -44,6 +43,8 @@ class ServerPacketizer : public base::RefCounted<ServerPacketizer>,
virtual int max_message_payload() const OVERRIDE;
private:
+ friend class base::RefCounted<ServerPacketizer>;
+
enum State {
NONE, // The initial state, before listen.
LISTENING, // Listening for packets.
@@ -52,6 +53,8 @@ class ServerPacketizer : public base::RefCounted<ServerPacketizer>,
typedef std::map<ConnectionKey, Packetizer::Listener*> ListenerMap;
typedef std::map<ConnectionKey, IPEndPoint> ConnectionMap;
+ virtual ~ServerPacketizer();
+
// Callbacks when an internal IO is completed.
void OnReadComplete(int result);
void OnWriteComplete(int result);

Powered by Google App Engine
This is Rietveld 408576698