Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: chrome/browser/jankometer.cc

Issue 10392152: RefCounted types should not have public destructors, Linux fixes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/jankometer.cc
diff --git a/chrome/browser/jankometer.cc b/chrome/browser/jankometer.cc
index df1355b899321ab188fe68bbbe720c4466ce71b6..3884867b07cad28e35a72e1743552d67400a3dbe 100644
--- a/chrome/browser/jankometer.cc
+++ b/chrome/browser/jankometer.cc
@@ -221,8 +221,6 @@ class IOJankObserver : public base::RefCountedThreadSafe<IOJankObserver>,
bool watchdog_enable)
: helper_(thread_name, excessive_duration, watchdog_enable) {}
- ~IOJankObserver() {}
-
// Attaches the observer to the current thread's message loop. You can only
// attach to the current thread, so this function can be invoked on another
// thread to attach it.
@@ -262,6 +260,8 @@ class IOJankObserver : public base::RefCountedThreadSafe<IOJankObserver>,
private:
friend class base::RefCountedThreadSafe<IOJankObserver>;
+ ~IOJankObserver() {}
+
JankObserverHelper helper_;
DISALLOW_COPY_AND_ASSIGN(IOJankObserver);

Powered by Google App Engine
This is Rietveld 408576698