Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(41)

Unified Diff: chrome/browser/ui/login/login_prompt_gtk.cc

Issue 10392152: RefCounted types should not have public destructors, Linux fixes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/login/login_prompt_gtk.cc
diff --git a/chrome/browser/ui/login/login_prompt_gtk.cc b/chrome/browser/ui/login/login_prompt_gtk.cc
index 717c0a5763d5fe81b0b7008e7bf15ce83eac8ea3..6a1d3e33f944d842b7b0f01fa18c948222df0a30 100644
--- a/chrome/browser/ui/login/login_prompt_gtk.cc
+++ b/chrome/browser/ui/login/login_prompt_gtk.cc
@@ -45,10 +45,6 @@ class LoginHandlerGtk : public LoginHandler,
ok_(NULL) {
}
- virtual ~LoginHandlerGtk() {
- root_.Destroy();
- }
-
// LoginModelObserver implementation.
virtual void OnAutofillDataAvailable(const string16& username,
const string16& password) {
@@ -142,6 +138,11 @@ class LoginHandlerGtk : public LoginHandler,
ReleaseSoon();
}
+ protected:
+ virtual ~LoginHandlerGtk() {
+ root_.Destroy();
+ }
+
private:
friend class LoginPrompt;

Powered by Google App Engine
This is Rietveld 408576698