Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(575)

Unified Diff: ui/gl/gl_surface_egl.h

Issue 10392152: RefCounted types should not have public destructors, Linux fixes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/gl/gl_surface_egl.h
diff --git a/ui/gl/gl_surface_egl.h b/ui/gl/gl_surface_egl.h
index dc6f4182cede49cc131229464a3a79967462ab6e..bce22061d2759d83f200bd784c4632ecef0aef4f 100644
--- a/ui/gl/gl_surface_egl.h
+++ b/ui/gl/gl_surface_egl.h
@@ -33,7 +33,6 @@ namespace gfx {
class GL_EXPORT GLSurfaceEGL : public GLSurface {
public:
GLSurfaceEGL();
- virtual ~GLSurfaceEGL();
// Implement GLSurface.
virtual EGLDisplay GetDisplay() OVERRIDE;
@@ -44,6 +43,8 @@ class GL_EXPORT GLSurfaceEGL : public GLSurface {
static EGLNativeDisplayType GetNativeDisplay();
protected:
+ virtual ~GLSurfaceEGL();
+
bool software_;
private:
@@ -54,7 +55,6 @@ class GL_EXPORT GLSurfaceEGL : public GLSurface {
class NativeViewGLSurfaceEGL : public GLSurfaceEGL {
public:
NativeViewGLSurfaceEGL(bool software, gfx::AcceleratedWidget window);
- virtual ~NativeViewGLSurfaceEGL();
// Implement GLSurface.
virtual EGLConfig GetConfig() OVERRIDE;
@@ -68,6 +68,7 @@ class NativeViewGLSurfaceEGL : public GLSurfaceEGL {
virtual bool PostSubBuffer(int x, int y, int width, int height) OVERRIDE;
protected:
+ virtual ~NativeViewGLSurfaceEGL();
void SetHandle(EGLSurface surface);
private:
@@ -83,7 +84,6 @@ class NativeViewGLSurfaceEGL : public GLSurfaceEGL {
class GL_EXPORT PbufferGLSurfaceEGL : public GLSurfaceEGL {
public:
PbufferGLSurfaceEGL(bool software, const gfx::Size& size);
- virtual ~PbufferGLSurfaceEGL();
// Implement GLSurface.
virtual EGLConfig GetConfig() OVERRIDE;
@@ -96,6 +96,9 @@ class GL_EXPORT PbufferGLSurfaceEGL : public GLSurfaceEGL {
virtual EGLSurface GetHandle() OVERRIDE;
virtual void* GetShareHandle() OVERRIDE;
+ protected:
+ virtual ~PbufferGLSurfaceEGL();
+
private:
gfx::Size size_;
EGLSurface surface_;

Powered by Google App Engine
This is Rietveld 408576698