Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 10391044: retry 136193 - convert localStrings to loadTimeData for options page (Closed)

Created:
8 years, 7 months ago by Evan Stade
Modified:
8 years, 7 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, tfarina, arv (Not doing code reviews), nkostylev+watch_chromium.org
Visibility:
Public.

Description

retry 136193 - convert localStrings to loadTimeData for options page now with fixes for chromeos failures that trybots politely failed to inform me about BUG=122753 TEST=manual Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=137067

Patch Set 1 #

Patch Set 2 : plugins, ui_account_tweaks fixes #

Total comments: 4

Patch Set 3 : sync #

Unified diffs Side-by-side diffs Delta from patch set Stats (+282 lines, -284 lines) Patch
M chrome/browser/resources/chromeos/keyboard_overlay.html View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/keyboard_overlay.js View 1 2 4 chunks +13 lines, -9 lines 0 comments Download
M chrome/browser/resources/chromeos/proxy_settings.js View 2 chunks +0 lines, -3 lines 0 comments Download
M chrome/browser/resources/options2/autofill_edit_address_overlay.js View 3 chunks +6 lines, -7 lines 0 comments Download
M chrome/browser/resources/options2/autofill_edit_creditcard_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/autofill_options.js View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/options2/autofill_options_list.js View 2 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/resources/options2/browser_options.html View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/resources/options2/browser_options.js View 1 2 13 chunks +24 lines, -21 lines 0 comments Download
M chrome/browser/resources/options2/browser_options_profile_list.js View 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/resources/options2/browser_options_startup_page_list.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/certificate_edit_ca_trust_overlay.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/certificate_import_error_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/certificate_manager.js View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/options2/certificate_tree.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/accounts_options.js View 2 chunks +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/accounts_user_list.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/bluetooth_add_device_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/bluetooth_device_list.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/bluetooth_pair_device_overlay.js View 5 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/cellular_plan_element.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/change_picture_options.js View 5 chunks +6 lines, -6 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/internet_detail.js View 1 2 5 chunks +17 lines, -17 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/keyboard_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/network_list.js View 14 chunks +19 lines, -19 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/pointer_overlay.html View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/pointer_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/set_wallpaper_options.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/chromeos/virtual_keyboard.js View 1 chunk +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options2/chromeos/virtual_keyboard_list.js View 2 chunks +1 line, -3 lines 0 comments Download
M chrome/browser/resources/options2/clear_browser_data_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/content_settings.js View 3 chunks +5 lines, -4 lines 0 comments Download
M chrome/browser/resources/options2/content_settings_exceptions_area.js View 5 chunks +12 lines, -11 lines 0 comments Download
M chrome/browser/resources/options2/controlled_setting.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/options2/cookies_list.js View 5 chunks +14 lines, -16 lines 0 comments Download
M chrome/browser/resources/options2/cookies_view.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/font_settings.js View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options2/handler_options.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/handler_options_list.js View 3 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/options2/home_page_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/import_data_overlay.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/instant_confirm_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/language_add_language_overlay.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/language_list.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/language_options.js View 16 chunks +26 lines, -22 lines 0 comments Download
M chrome/browser/resources/options2/manage_profile_overlay.js View 4 chunks +4 lines, -5 lines 0 comments Download
M chrome/browser/resources/options2/options.html View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/options2/options.js View 1 2 2 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/resources/options2/options_page.js View 1 2 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/browser/resources/options2/password_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/password_manager_list.js View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/options2/search_engine_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/search_engine_manager_engine_list.js View 3 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/resources/options2/search_page.js View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/options2/session_restore_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/spelling_confirm_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options2/startup_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/plugins.html View 1 1 chunk +6 lines, -5 lines 0 comments Download
M chrome/browser/resources/shared/js/chromeos/ui_account_tweaks.js View 1 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/resources/shared/js/i18n_template_no_process.js View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/sync_promo/sync_promo.html View 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/resources/sync_promo/sync_promo.js View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/resources/sync_setup_overlay.js View 4 chunks +6 lines, -5 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/keyboard_overlay_ui.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/chromeos/ui_account_tweaks.cc View 1 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/accounts_options_handler2.cc View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/chromeos/change_picture_options_handler2.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/ui/webui/options2/options_ui2.cc View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/plugins_ui.cc View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/ui/webui/sync_promo/sync_promo_ui.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Evan Stade
fixes are in chromeos keyboard overlay, plugins page (which is now also on loadTimeData), ui_account_tweaks.js ...
8 years, 7 months ago (2012-05-10 20:51:22 UTC) #1
Evan Stade
oh yeah, and the chromeos unit test failure is unrelated it seems. I can't repro ...
8 years, 7 months ago (2012-05-10 20:52:11 UTC) #2
Dan Beam
https://chromiumcodereview.appspot.com/10391044/diff/8001/chrome/browser/resources/plugins.html File chrome/browser/resources/plugins.html (left): https://chromiumcodereview.appspot.com/10391044/diff/8001/chrome/browser/resources/plugins.html#oldcode205 chrome/browser/resources/plugins.html:205: <script src="chrome://plugins/strings.js"></script> how in the hell did this work ...
8 years, 7 months ago (2012-05-11 04:25:41 UTC) #3
Evan Stade
http://codereview.chromium.org/10391044/diff/8001/chrome/browser/resources/plugins.html File chrome/browser/resources/plugins.html (right): http://codereview.chromium.org/10391044/diff/8001/chrome/browser/resources/plugins.html#newcode212 chrome/browser/resources/plugins.html:212: <script src="chrome://plugins/strings.js"></script> On 2012/05/11 04:25:41, Dan Beam wrote: > ...
8 years, 7 months ago (2012-05-14 22:29:34 UTC) #4
Dan Beam
8 years, 7 months ago (2012-05-14 22:34:02 UTC) #5 
lgtm

http://codereview.chromium.org/10391044/diff/8001/chrome/browser/resources/pl...
File chrome/browser/resources/plugins.html (right):

http://codereview.chromium.org/10391044/diff/8001/chrome/browser/resources/pl...
chrome/browser/resources/plugins.html:212: <script
src="chrome://plugins/strings.js"></script>
On 2012/05/14 22:29:35, Evan Stade wrote:
> On 2012/05/11 04:25:41, Dan Beam wrote:
> > why strings first?
> 
> strings.js always has to be before i18n_template2.js

oh, it calls process, OK

Powered by Google App Engine
This is Rietveld 408576698