chrome/browser/resources/shared/js/i18n_template_no_process.js - Issue 10391044: retry 136193 - convert localStrings to loadTimeData for options page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/shared/js/i18n_template_no_process.js

Issue 10391044: retry 136193 - convert localStrings to loadTimeData for options page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sync Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/resources/shared/js/i18n_template_no_process.js

diff --git a/chrome/browser/resources/shared/js/i18n_template_no_process.js b/chrome/browser/resources/shared/js/i18n_template_no_process.js

index cce85bed6190b9ecd5fa369a768bf98c004bf9e7..fc4ca7d63387b44c6ff120ebfb7eefcdb96559c7 100644

--- a/chrome/browser/resources/shared/js/i18n_template_no_process.js

+++ b/chrome/browser/resources/shared/js/i18n_template_no_process.js

@@ -53,7 +53,7 @@ var i18nTemplate = (function() {

* @param {LoadTimeData} dictionary The dictionary of strings to draw from.

'i18n-options': function(select, key, dictionary) {

- var options = dictionary.getString(key);

+ var options = dictionary.getValue(key);

options.forEach(function(optionData) {

var option = typeof optionData == 'string' ?

new Option(optionData) :