chrome/browser/resources/options2/browser_options_startup_page_list.js - Issue 10391044: retry 136193 - convert localStrings to loadTimeData for options page

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options2/browser_options_startup_page_list.js

Issue 10391044: retry 136193 - convert localStrings to loadTimeData for options page (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: sync Created 8 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options2/browser_options_profile_list.js ('k') | chrome/browser/resources/options2/certificate_edit_ca_trust_overlay.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options2/browser_options_startup_page_list.js

diff --git a/chrome/browser/resources/options2/browser_options_startup_page_list.js b/chrome/browser/resources/options2/browser_options_startup_page_list.js

index 91daf1459ee0c8492a59b2b7f8bea9f86ebe5378..f88e5d41c2ee273a0e18facd394016786fe7f573 100644

--- a/chrome/browser/resources/options2/browser_options_startup_page_list.js

+++ b/chrome/browser/resources/options2/browser_options_startup_page_list.js

@@ -47,7 +47,7 @@ cr.define('options.browser_options', function() {

if (pageInfo['modelIndex'] == '-1') {

this.isPlaceholder = true;

- pageInfo['title'] = localStrings.getString('startupAddLabel');

+ pageInfo['title'] = loadTimeData.getString('startupAddLabel');

pageInfo['url'] = '';

}

@@ -71,7 +71,7 @@ cr.define('options.browser_options', function() {

var urlField = urlEl.querySelector('input');

urlField.className = 'weakrtl';

- urlField.placeholder = localStrings.getString('startupPagesPlaceholder');

+ urlField.placeholder = loadTimeData.getString('startupPagesPlaceholder');

this.urlField_ = urlField;

this.addEventListener('commitedit', this.onEditCommitted_);